boost::property_tree::read_json fails on previously supported comments 1.59
I recently upgraded from 1.56 to 1.59 and my hundreds of well commented JSON parameter files now all fail on the first commented line. This is true for /* */ and // style comments. The exception.what() string thrown by boost::property_tree::read_json(filename,propertyTree) is filename.json(linenumber): expected key string. As I remove comments from my test JSON file the line number advances to the next comment. Any hints as to how to deal with this? Removing all my comments is not an option. Thanks, Mark --
This issue also presents in 1.60
On Fri, Dec 18, 2015 at 8:24 AM, Millman, Mark
I recently upgraded from 1.56 to 1.59 and my hundreds of well commented JSON parameter files now all fail on the first commented line. This is true for /* */ and // style comments.
The exception.what() string thrown by boost::property_tree::read_json(filename,propertyTree) is
filename.json(linenumber): expected key string.
As I remove comments from my test JSON file the line number advances to the next comment.
Any hints as to how to deal with this? Removing all my comments is not an option.
Thanks, Mark
--
-- Mark Millman | Mizar, LLC mark.millman@mizar.com | www.mizar.com (702) 799-9968 9908 Alegria Dr | Las Vegas, NV 89144 The information contained in this communication may be confidential, is intended only for the use of the recipient(s) named above, and may be legally privileged. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this communication, or any of its contents, is strictly prohibited. If you have received this communication in error, please return it to the sender immediately and delete the original message and any copy of it from your computer system. If you have any questions concerning this message, please contact the sender.
On 12/18/2015 1:24 PM, Millman, Mark wrote:
I recently upgraded from 1.56 to 1.59 and my hundreds of well commented JSON parameter files now all fail on the first commented line. This is true for /* */ and // style comments.
This is listed as a breaking change in the release notes at http://www.boost.org/users/history/version_1_59_0.html
Any hints as to how to deal with this? Removing all my comments is not an option.
If you must use nonstandard JSON then you might want to stick with 1.58, or otherwise write your own parser. Regards, -- Agustín K-ballo Bergé.- http://talesofcpp.fusionfenix.com
If this is an official upgrade -- to no longer support comments -- then I'll write myself a file-to-stream comment stripper and pass the stream to read_json. As a consumer of JSON and Boost it seems like a poor choice to drop something that is so useful and has been supported for so long. Thanks for the information though. Mark On Fri, Dec 18, 2015 at 10:45 AM, Agustín K-ballo Bergé < kaballo86@hotmail.com> wrote:
On 12/18/2015 1:24 PM, Millman, Mark wrote:
I recently upgraded from 1.56 to 1.59 and my hundreds of well commented JSON parameter files now all fail on the first commented line. This is true for /* */ and // style comments.
This is listed as a breaking change in the release notes at http://www.boost.org/users/history/version_1_59_0.html
Any hints as to how to deal with this? Removing all my comments is not
an option.
If you must use nonstandard JSON then you might want to stick with 1.58, or otherwise write your own parser.
Regards, -- Agustín K-ballo Bergé.- http://talesofcpp.fusionfenix.com _______________________________________________ Boost-users mailing list Boost-users@lists.boost.org http://lists.boost.org/mailman/listinfo.cgi/boost-users
-- Mark Millman | Mizar, LLC mark.millman@mizar.com | www.mizar.com (702) 799-9968 9908 Alegria Dr | Las Vegas, NV 89144 The information contained in this communication may be confidential, is intended only for the use of the recipient(s) named above, and may be legally privileged. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this communication, or any of its contents, is strictly prohibited. If you have received this communication in error, please return it to the sender immediately and delete the original message and any copy of it from your computer system. If you have any questions concerning this message, please contact the sender.
On 12/18/2015 3:51 PM, Millman, Mark wrote:
If this is an official upgrade -- to no longer support comments -- then I'll write myself a file-to-stream comment stripper and pass the stream to read_json.
As a consumer of JSON and Boost it seems like a poor choice to drop something that is so useful and has been supported for so long.
I understand your position, but something "just working" is not the same than something being supported. I cannot find any mention of nonstandard comment support in the documentation for 1.58. All I see is a link to a Wikipedia article, which reads "JSON does not provide or allow any sort of comment syntax". Regards, -- Agustín K-ballo Bergé.- http://talesofcpp.fusionfenix.com
Yes, I understand and acknowledge that unfortunately JSON does not officially support comments. I consider it a significant issue with the standard. I like to use JSON in preference to XML (let alone INI) for parameter files and have a considerable suite of programs that leverage it. The parameter files can be quite complex and the master templates are all annotated to provide users with the acceptable options and ranges. So, it's unfortunate but I'll blame JSON and not Boost. I'll just write a file-to-stream reader that strips out the comments and pass the stream to read_json. Still a "Booster" Mark. (How much do you want to be that they add comments to the JSON standard next month?) msm ;-) On Fri, Dec 18, 2015 at 11:05 AM, Agustín K-ballo Bergé < kaballo86@hotmail.com> wrote:
On 12/18/2015 3:51 PM, Millman, Mark wrote:
If this is an official upgrade -- to no longer support comments -- then I'll write myself a file-to-stream comment stripper and pass the stream to read_json.
As a consumer of JSON and Boost it seems like a poor choice to drop something that is so useful and has been supported for so long.
I understand your position, but something "just working" is not the same than something being supported. I cannot find any mention of nonstandard comment support in the documentation for 1.58. All I see is a link to a Wikipedia article, which reads "JSON does not provide or allow any sort of comment syntax".
Regards, -- Agustín K-ballo Bergé.- http://talesofcpp.fusionfenix.com _______________________________________________ Boost-users mailing list Boost-users@lists.boost.org http://lists.boost.org/mailman/listinfo.cgi/boost-users
-- Mark Millman | Mizar, LLC mark.millman@mizar.com | www.mizar.com (702) 799-9968 9908 Alegria Dr | Las Vegas, NV 89144 The information contained in this communication may be confidential, is intended only for the use of the recipient(s) named above, and may be legally privileged. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this communication, or any of its contents, is strictly prohibited. If you have received this communication in error, please return it to the sender immediately and delete the original message and any copy of it from your computer system. If you have any questions concerning this message, please contact the sender.
participants (2)
-
Agustín K-ballo Bergé -
Millman, Mark