[boost] integrating NaCl support into boost
Hi boost community, how about integrating NaCl support patches into the boost main-line (trunk/master), I am talking about these NaCl ports patches: https://chromium.googlesource.com/external/naclports/+/master/ports/boost (I actually have a bit more correct patches that allow to compile boost 1.59 for NaCl platforms, while Google patches are still for 1.55). I would be grateful to hear suggestion about how to process with it, e.g. which actions should I take to make it really happen. I personally suppose making boost to officially support more platforms will make boost more popular and allow more developers to use it and port their applications to other platforms. I look forward to hearing from you soon. yours sincerely, Konstantin
Konstantin Ivlev <tomskside <at> gmail.com> writes:
Hi boost community, how about integrating NaCl support patches into the boost main-line (trunk/master), I am talking about these NaCl ports patches:
https://chromium.googlesource.com/external/naclports/+/master/ports/boost
(I actually have a bit more correct patches that allow to compile boost 1.59 for NaCl platforms, while Google patches are still for 1.55).
I would be grateful to hear suggestion about how to process with it, e.g. which actions should I take to make it really happen.
I think posting this on the Boost.Devel [1] mailing list might increase the chance of someone picking this up. I know some people don't look at the Boost.User list as often, so that could explain why this has gone unnoticed.
[...]
Regards, Louis [1]: http://news.gmane.org/gmane.comp.lib.boost.devel
On 9/15/2015 4:46 PM, Louis Dionne wrote:
Konstantin Ivlev <tomskside <at> gmail.com> writes:
Hi boost community, how about integrating NaCl support patches into the boost main-line (trunk/master), I am talking about these NaCl ports patches:
https://chromium.googlesource.com/external/naclports/+/master/ports/boost
(I actually have a bit more correct patches that allow to compile boost 1.59 for NaCl platforms, while Google patches are still for 1.55).
I would be grateful to hear suggestion about how to process with it, e.g. which actions should I take to make it really happen.
I think posting this on the Boost.Devel [1] mailing list might increase the chance of someone picking this up. I know some people don't look at the Boost.User list as often, so that could explain why this has gone unnoticed.
[...]
Regards, Louis
I agree and want to add that more information on what areas of Boost these patches cover might also be appropriate in a post on the Boost developers list.
On 03-Sep-15 6:10 AM, Konstantin Ivlev wrote:
Hi boost community,
how about integrating NaCl support patches into the boost main-line (trunk/master), I am talking about these NaCl ports patches:
https://chromium.googlesource.com/external/naclports/+/master/ports/boost
Beside suggestion to raise this on boost-devel, I'd also suggest you explain what these patches are. I guess that NaCl is Google's Native Client thing, but beyond that, I have no idea what these patches are and what they do. Also, some quick comments: - # if defined(__CYGWIN__) || defined(__USE_GNU) + # if defined(__CYGWIN__) || defined(__USE_GNU) || defined _NEWLIB_VERSION This hunk better use the same formatting as the rest of the Boost code, that is # if defined(__CYGWIN__) || defined(__USE_GNU) || defined(_NEWLIB_VERSION) There are several other places in the patch where I'd suggest using this style as opposed to #ifndef or #ifdef - case * : option = -pthread ; libs = rt ; + case * : option = -pthread ; } This hunk can't be applied as is, you'd need to introduce a new case clause to catch NaCL. - Volodya
participants (1)
-
Edward Diener -
Konstantin Ivlev -
Louis Dionne -
Vladimir Prus