[math] round to fraction
Hello all, I couldn't find a functionality like 'round to fraction', which would try round a floating point value to its nearby fraction portion: round2fraction(1.4, 0.5); -> 1.5 round2fraction(1.8, 0.5); -> 2.0 round2fraction(1.0, 0.5); -> 1.0 round2fraction(1.25, 0.5); -> 1.5 round2fraction(-1.6, 0.5); -> -1.5 We have here a private implementation, but this is probably not as optimised as those numerical guru's can come up with. Is this a good suggestion to add to Boost.Math or overkill?
I couldn't find a functionality like 'round to fraction', which would try round a floating point value to its nearby fraction portion:
round2fraction(1.4, 0.5); -> 1.5 round2fraction(1.8, 0.5); -> 2.0 round2fraction(1.0, 0.5); -> 1.0 round2fraction(1.25, 0.5); -> 1.5 round2fraction(-1.6, 0.5); -> -1.5
We have here a private implementation, but this is probably not as optimised as those numerical guru's can come up with. Is this a good suggestion to add to Boost.Math or overkill?
Probably overkill to add to Boost.Math, but how about: template <class T> T round2fraction(T x, T f) { return f * round(x/f); } where "round" is either the C99 one or the boost::math:: one if you need something more generic. Of course this assumes that parameter "f" is exactly representable as a floating point value, in fact it might need to be a power of 2 in order to be certain of being completely safe and accurate.... HTH, John.
On Tue, Oct 26, 2010 at 10:01, John Maddock <boost.regex@virgin.net> wrote:
Of course this assumes that parameter "f" is exactly representable as a floating point value, in fact it might need to be a power of 2 in order to be certain of being completely safe and accurate....
"Safe and accurate" is always far beyond my ability to prove when it comes to floating point. Even if f is a power of two, what is something like round2fraction(sqrt(1e41), 4) supposed to do? Perhaps the best it can promise is something like "when the result is displayed with digits10-1 significant figures, it will appear to have been rounded as requested".
On 10/26/2010 12:27 PM, Scott McMurray wrote:
On Tue, Oct 26, 2010 at 10:01, John Maddock<boost.regex@virgin.net> wrote:
Of course this assumes that parameter "f" is exactly representable as a floating point value, in fact it might need to be a power of 2 in order to be certain of being completely safe and accurate....
"Safe and accurate" is always far beyond my ability to prove when it comes to floating point.
Yeah mine too. Still, I always though multiplication and division by powers of two was one thing it was expected to do well. Seems like it could usually just change the exponent and not lose any precision in the mantissa.
Even if f is a power of two, what is something like round2fraction(sqrt(1e41), 4) supposed to do?
The magnitude of 1e41, sqrt(1e41), and sqrt(1e41)*4 all fit neatly into double precision, so couldn't round2fraction give an exact answer in this case?
Perhaps the best it can promise is something like "when the result is displayed with digits10-1 significant figures, it will appear to have been rounded as requested".
It doesn't sound to me like it's any worse than your typical floating point multiplication (well, maybe two of them). Perhaps you could define the precision of its result as being "no worse, on average, than the expression f*round(x/f)". :-) - Marsh
participants (1)
-
gast128 -
John Maddock -
Marsh Ray -
Scott McMurray