2011/3/6 Christian Henning :

Hi Szymon, the new IO extension isn't yet part of boost. Are you referring to my repository at good code?

Also there is no png_load_file() in the old version nor is there a load_image() in the new IO. The test code reads and writes png's in various formats. What is your format? A little code would be nice, too. ;-)

Sorry for not checking for valid function names. I used this code: http://gil-contributions.googlecode.com/files/boost_review.zip. A little portion of my code then ;) using namespace boost::gil; typedef boost::mpl::vector image_types; any_image image; try { png_read_image(file, image); //read_image(file, image, png_tag()); init(); if (image.current_type_is()) { setData(view(image._dynamic_cast())); } else if (image.current_type_is()) { setData(view(image._dynamic_cast())); } } catch (const std::exception& e) { throw Exception(e.what()) << ". File: " << file; } this is a snippet from implementation of 2D OpenGL texture. setData() is overloaded for various image formats so that valid constant is passed to GL Api (rgb8_image_t image overload passes GL_RGB8 etc). I didn't do anything but changing png_read_image() to read_image() and after running app all images on screen were broken - most of images is white. On a side note: maybe new io could use boost::exception? Would be great if read_image() used boost::errinfo_file_name() when file cannot be opened as now it is not better than just returning error code.

2011/3/7 Christian Henning :

could you try to load images without using any_image<...>. Also can you try to load one of the png files from the test_images folder?

What system to you work on? What's the compiler?

New info: - using Visual Studio 2008 SP1 - it only happens in Release mode (often suggests uninitialized variables) - attaching screen shoot of application displaying test.png from test_images (in Debug mode all is fine) Cheers, Szymon

Hi Szymon, sorry to see you keep having issues with gil::io.

New info:

- using Visual Studio 2008 SP1 - it only happens in Release mode (often suggests uninitialized variables) - attaching screen shoot of application displaying test.png from test_images (in Debug mode all is fine)

I did try a couple of things but couldn't reproduce your issue. I made sure to use the boost_review code version. I tried debug/release version with VS2010 and VS2008 for 64bit. What's your version of your lib png? Here is the code I tried: #include #define BOOST_FILESYSTEM_VERSION 2 #include #include #define BOOST_GIL_IO_ADD_FS_PATH_SUPPORT #include using namespace boost; using namespace gil; int main() { rgba8_image_t img; read_image( "C:\\gil_contribution\\test_images\\png\\wikipedia\\test.png", img, png_tag() ); write_view( "c:\\out.png", view( img ), png_tag() ); return 0; } Regards, Christian

2011/3/14 Szymon Gatner :

2011/3/8 Christian Henning :

...

Here is the code I tried:

#include

#define BOOST_FILESYSTEM_VERSION 2 #include

#include

#define BOOST_GIL_IO_ADD_FS_PATH_SUPPORT #include

using namespace boost; using namespace gil;

int main() {    rgba8_image_t img;

   read_image( "C:\\gil_contribution\\test_images\\png\\wikipedia\\test.png", img, png_tag() );

   write_view( "c:\\out.png", view( img ), png_tag() );

   return 0; }

Very sorry for late reply, been too busy to do additional testing.

Your code works for for me also, but worst part is, I was not able to provide minimal test code that demonstrates what I experience in the main project as it works fine also. I will still try to do that and hopefully got some more info when it is done.

Thanks for your support and especially on work with GIL.

Cherrs, Szymon

Hi again, took a while but finally got some time to do some additional testing. I wrote small app: #include <fstream> #include #include using namespace boost; int main() { gil::rgba8_image_t img; gil::read_image("test.png", img, gil::png_tag()); std::ofstream os("dump.txt"); int size = sizeof(gil::rgba8_pixel_t); BOOST_FOREACH(const gil::rgba8_pixel_t& pix, std::make_pair(img._view.begin(), img._view.end())) { os << (int) pix[0] << " " << (int) pix[1] << " " << (int) pix[2] << " " << (int) pix[3] << "\n"; } } that code produces different text files when built in debug and release modes and observed text file difference is exactly what I also experience on the screen. For example: debug: 23 74 23 9 0 0 0 0 24 83 24 25 0 0 0 0 24 82 24 43 24 83 24 36 24 83 24 47 24 81 24 52 24 82 24 45 23 81 23 45 23 80 23 41 0 0 0 0 23 79 23 32 release: 255 255 255 9 0 0 0 0 255 255 255 25 0 0 0 0 255 255 255 43 255 255 255 36 255 255 255 47 255 255 255 52 255 255 255 45 255 255 255 45 255 255 255 41 0 0 0 0 255 255 255 32 Alpha channels is preserved but R G B channels are saturated to 255 always. Cheers, Simon

Hey Christian, 2011/4/27 Christian Henning :

Hi Szymon,

...

#include <fstream> #include #include

using namespace boost;

int main() {  gil::rgba8_image_t img;

 gil::read_image("test.png", img, gil::png_tag());

 std::ofstream os("dump.txt");

 int size = sizeof(gil::rgba8_pixel_t);

 BOOST_FOREACH(const gil::rgba8_pixel_t& pix, std::make_pair(img._view.begin(), img._view.end()))  {    os << (int) pix[0] << " " << (int) pix[1] << " " << (int) pix[2] << " " << (int) pix[3] << "\n";  } }

that code produces different text files when built in debug and release modes and observed text file difference is exactly what I also experience on the screen. For example:

I have tried your code and cannot recreate your problem. Both dump.txt files have exactly the same data inside. What compiler do you use and what architecture do you work on?

Visual C++ 2008 SP1, Win7 x64 building app as 32 bit. Using libpng 1.2.44 as I was not able to build with 1.5 branch.

Hi Szymon, patients pays off some times. ;-) I could locate the problem and it turns out it was a simple issue of missing to initialize member variables. Please get the latest and try again. I also added support for new libpng 1.5. Thanks for your patience and using the new gil:io. Christian On Wed, Apr 27, 2011 at 3:24 PM, Christian Henning wrote:

Hi Szymon, I could recreate your problem with Visual Studio 2010 in 32bit. The problem does not occur with 64bit. I'll have a look later what the problem is.

Thanks for reporting, Christian

On Wed, Apr 27, 2011 at 10:37 AM, Szymon Gatner wrote:

...

Hey Christian,

2011/4/27 Christian Henning :

...

Hi Szymon,

...

#include <fstream> #include #include

using namespace boost;

int main() {  gil::rgba8_image_t img;

 gil::read_image("test.png", img, gil::png_tag());

 std::ofstream os("dump.txt");

 int size = sizeof(gil::rgba8_pixel_t);

 BOOST_FOREACH(const gil::rgba8_pixel_t& pix, std::make_pair(img._view.begin(), img._view.end()))  {    os << (int) pix[0] << " " << (int) pix[1] << " " << (int) pix[2] << " " << (int) pix[3] << "\n";  } }

that code produces different text files when built in debug and release modes and observed text file difference is exactly what I also experience on the screen. For example:

I have tried your code and cannot recreate your problem. Both dump.txt files have exactly the same data inside. What compiler do you use and what architecture do you work on?

Visual C++ 2008 SP1, Win7 x64 building app as 32 bit.

Using libpng 1.2.44 as I was not able to build with 1.5 branch. _______________________________________________ Boost-users mailing list Boost-users@lists.boost.org http://lists.boost.org/mailman/listinfo.cgi/boost-users