31 Aug
2015
31 Aug
'15
2:15 p.m.
On 30 Aug 2015 at 22:25, Gruenke,Matt wrote:
In both cases, there should be a clear comment that explains why the code is disabled. While AFIO has such comments (though often quite terse) in some cases, there are several where it seems the reader is left to guess why it has been left in the code, but disabled.
In short, there should always be a clear purpose behind leaving an #if 0'd block in the code. As long as that's true, it shouldn't be hard to state that in a brief, clear comment.
Yes, I agree. Logged to https://github.com/BoostGSoC13/boost.afio/issues/109. Niall -- ned Productions Limited Consulting http://www.nedproductions.biz/ http://ie.linkedin.com/in/nialldouglas/