I'm not a reviewer, but I'd like to add a note on the interface: I think boost::charconv should add one convenience function as follows: // Returns std::nullopt on error template <typename NumberType> std::optional<NumberType> boost::charconv::to_number(const std::string_view& sv) noexcept; Reason: Right now there is no simple, non-throwing way of converting a string to a number in C++ as std::stoi/std::stof throws exceptions on errors. Best/Viktor On Mon, Jan 15, 2024 at 11:31 AM Christopher Kormanyos via Boost < boost@lists.boost.org> wrote:
Dear all,
The review of Boost.Charconv by Matt Borland runs Monday, January 15th through January 25th, 2024.
Code: https://github.com/cppalliance/charconvDocs: https://master.charconv.cpp.al/Review Schedule: https://www.boost.org/community/review_schedule.html
Thank you for considering this review.
Please optionally provide feedback on the followinggeneral topics:
- What is your evaluation of the design? - What is your evaluation of the implementation? - What is your evaluation of the documentation? - What is your evaluation of the potential usefulness of the library? - Did you try to use the library? With what compiler? Did you have any problems? - How much effort did you put into your evaluation? A glance? A quick reading? In-depth study? - Are you knowledgeable about the problem domain?
Christopher KormanyosBoost.Charconv Review Manager
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost