Fletcher, John P
Here is my review and some comments.
[...]
* Documentation
It is not always clear exactly which headers are needed for any given example from the manual. It is necessary to look at the example codes.
Right; I guess either the examples should be more self-contained, or the headers required for each algorithm should be documented more explicitly. Added this issue [1].
I would like more information about some topics, e.g. monads and comonads.
Monads, Comonads & al are a very big subject, and Hana can't take on the burden of explaining those concepts a lot more than it already does. I will, however, provide more links to external resources so that readers are not left with a simple "there are a lot of resources out there", but instead with concrete pointers. See this issue [2].
[...]
- Did you attempt to use the library? YES If so: * Which compiler(s)? Clang 3.5 and 3.6 with libc++ running on Ubuntu 12.04
* What was the experience? Any problems? No - How much effort did you put into your evaluation of the review? I have spent some hours implementing examples and running them.
Thank you for the review, John! Regards, Louis [1]: https://github.com/ldionne/hana/issues/133 [2]: https://github.com/ldionne/hana/issues/134