On 6 Jun 2014 at 9:51, Paul A. Bristow wrote:
Since the review hasn't started, change all you like.
I unhappy with a review rigid policy that nothing can be changed during a review. It isn't always helpful.
We never accept anything without requiring some changes?
Can we instead now use git's easy branches to specify a fixed 'master' branch, but allow the author to update a 'develop' branch as the review develops?
That way typos and more serious mistakes can be corrected as the review proceeds. This will avoid people being confused by these.
AFIO has a special 'boost-peer-review' branch (https://github.com/BoostGSoC13/boost.afio/tree/boost-peer-review) intended for peer review. Said branch is the most stable of all stable branches. I would avoid using master branch, as sometimes you need to change master branch because other projects you depend on have changed. Niall -- ned Productions Limited Consulting http://www.nedproductions.biz/ http://ie.linkedin.com/in/nialldouglas/