On 22 Jul 2014 at 11:42, Eric Niebler wrote:
On 07/22/2014 10:13 AM, Stephan T. Lavavej wrote:
[Lars Viklund]
boost\range\adaptor\formatted.hpp is missing an inline on line 154 for range_detail::formatted_holder
formatted() This results in duplicate symbol linker errors in my project w/ VS2013.3RC. [Eric Niebler]
I took the liberty of fixing this myself. I also removed the executable bit on boost/range.hpp. I hope Neil doesn't mind.
Back in 2007 when we made the same mistake in <tuple>, I added an "include all STL headers in two TUs" test to prevent it from happening again, which has served us perfectly. Does Boost have the same thing for each of its libraries?
This is a good idea. I do it for xpressive, but I don't think there's anything comprehensive for all the boost libraries.
Agreed. I have this test too in AFIO, plus I cycle that test for everything headers only, AFIO headers only but ASIO not headers only, ASIO headers only but not AFIO headers only, and finally nothing headers only. I also cycle having one of the TUs use variadic templates and the other TU not. The reason for the dilligence is that I take advantage of inline virtual support/bug/misfeature when the compiler just happens to support it for headers-only builds, plus I keep forgetting to update the non-variadics support :( There is plenty of scope for unenforced errors to leak out if a CI doesn't help me. Niall -- ned Productions Limited Consulting http://www.nedproductions.biz/ http://ie.linkedin.com/in/nialldouglas/