On Wed, Aug 1, 2018 at 7:20 AM, Adam Wulkiewicz via Boost < boost@lists.boost.org> wrote:
Marshall Clow Via Boost wrote:
On Wed, Aug 1, 2018 at 5:16 AM, Adam Wulkiewicz via Boost < boost@lists.boost.org> wrote:
Marshall Clow Via Boost wrote:
The changes look fine to me.
Have the test bots cycled? If they have, then go ahead. If they have not, then wait until they have, and (assuming no problems) go ahead.
Is it still possible to push this MSVC workaround: https://github.com/boostorg/geometry/commit/319ee31d6acf30be c24b03cea3b19f26ab940aa1
Same questions as above.
That commit is two hours old - I doubt the test bots have cycled yet. The deadline is tonight (PDT).
If you're talking about Travis it has: https://travis-ci.org/boostorg/boost/builds/410777938 At CircleCI there is some failure but AFAIU it has nothing to do with Geometry and the next one passes: https://circleci.com/gh/boostorg/boost Regression for Geometry at CircleCI is ok too: https://circleci.com/workflow-run/a8d3be62-7e27-404a-8951-e0697542fb64
Then go ahead and merge. -- Marshall