Re: [boost] [review] Review of PolyCollection starts today (May 3rd)

On 5/10/2017 5:01 PM, Vinnie Falco via Boost wrote:

On Tue, May 2, 2017 at 4:46 PM, Ion Gaztañaga via Boost wrote:

...

The library can be found here: ... https://github.com/joaquintides/poly_collection

The documentation looks beautiful and I was excited by the positive review comments so I thought I would have a look. Unfortunately, I ran into considerable difficulty trying to actually build the example and poke around. There are no instructions on how to build that I could find in the repository or the documentation.

First I tried cloning the repository and building:

$ cd ~/src $ git clone git@github.com:joaquintides/poly_collection $ cd poly_collection/example $ b2

Produced this output: C:/Users/vinnie/lib/boost_1_64_0/tools/build/src/build\project.jam:111: in load-parent from module project error: Could not find parent for project at '.' error: Did not find Jamfile.jam or Jamroot.jam in any parent directory. C:/Users/vinnie/lib/boost_1_64_0/tools/build/src/build\project.jam:464: in initialize from module project C:/Users/vinnie/lib/boost_1_64_0/tools/build/src/build\project.jam:306: in load-jamfile from module project C:/Users/vinnie/lib/boost_1_64_0/tools/build/src/build\project.jam:64: in load from module project C:/Users/vinnie/lib/boost_1_64_0/tools/build/src/build\project.jam:145: in project.find from module project C:/Users/vinnie/lib/boost_1_64_0/tools/build/src\build-system.jam:535: in load from module build-system C:\Users\vinnie\lib\boost_1_64_0\tools\build\src/kernel\modules.jam:295: in import from module modules C:\Users\vinnie\lib\boost_1_64_0\tools\build\src/kernel/bootstrap.jam:139: in boost-build from module C:\Users\vinnie\lib\boost_1_64_0\boost-build.jam:17: in module scope from module

Now I remember some jibber jabber about putting projects in the live Boost directory (a practice which I am not fond of). In the interest of moving forward I tried it.

$ cd ~/lib/boost_1_64_0 $ git clone git@github.com:joaquintides/poly_collection $ cd poly_collection/example $ b2

It got a little farther this time but still does not build:

Performing configuration checks

- 32-bit : yes (cached) - arm : no (cached) - mips1 : no (cached) - power : no (cached) - sparc : no (cached) - x86 : yes (cached) ...patience... ...found 1033 targets... ...updating 23 targets... compile-c-c++ ..\..\bin.v2\poly_collection\example\msvc-14.1\debug\threading-multi\algorithms.obj algorithms.cpp algorithms.cpp(12): fatal error C1083: Cannot open include file: 'boost/poly_collection/algorithm.hpp': No such file or directory

1) Clone beneath the 'your_boost_tree_root/libs' directory 2) run 'b2 headers' from 'your_boost_tree_root' after you clone

Did I mention I am using Microsoft Visual Studio on Windows?

Full disclosure, I have had this problem twice before when trying to review libraries. In the past I have simply given up. But I want to contribute something back since my own library will be reviewed soon.

Regards