On 11/07/16 13:02, Daniel James wrote:
On 7 November 2016 at 08:16, Andrey Semashev
wrote: This solution relies on MSVC macros, so it won't work when other compilers remove the deprecated components.
From my email:
I wrote that before this thread, which is why I wrote it as a short term fix
From the commit message:
I'm not sure what the long term solution should be, but hopefully this will work for now.
If that wasn't clear enough, I was just trying to put in a short term fix for this release, so that it can be dealt with properly later. Changing the public inheritance of a class is a breaking change, and we're scheduled to close for beta in two days time.
IMHO, there's no point in a "short term fix" if it's messier and more complicated than a normal fix. I'd either keep the original code for 1.63 or do a proper fix. Removing the base class is formally a breaking change, but I doubt anyone will ever notice. But that's just my opinion.