On 08/16/17 17:28, Kurkov, Vasiliy A via Boost wrote:
Hi,
I am Vasiliy Kurkov and I'm working as QA engineer in Intel Compiler QA team.
I have tried to build boost libs from 1.65 beta, but I faced the following issue on Windows for new stacktrace lib:
compile-c-c++ bin.v2\libs\stacktrace\build\07984f9e4da2f3b833f7520e2f16f320\windbg_cached.obj
icl @"bin.v2\libs\stacktrace\build\07984f9e4da2f3b833f7520e2f16f320\windbg_cached.obj.rsp"
windbg_cached.cpp .\boost/stacktrace/detail/collect_unwind.ipp(17): catastrophic error: cannot open source file "unwind.h" #include
^ compilation aborted for libs\stacktrace\build\..\src\windbg_cached.cpp (code 4)
Environment: Windows 2016 Server + MSVS2017 + Intel Compiler 17.0 or later
I would like to suggested the following patch:
--- 1/boost_1_65_0/boost/stacktrace/safe_dump_to.hpp 2017-08-16 13:37:10.003950000 +0300 +++ 2/boost_1_65_0/boost/stacktrace/safe_dump_to.hpp 2017-08-16 13:38:05.470305000 +0300 @@ -203,7 +203,7 @@ # else # include
# endif -# if defined(BOOST_MSVC) +# if defined(BOOST_MSVC) || defined(BOOST_INTEL) # include # else # include Thank you in advance.
BOOST_INTEL is defined both on Windows and Linux, and I suspect collect_msvc.ipp is Windows-specific. You might want to check for BOOST_INTEL_WIN. Also, patches are typically posted as PRs.