If you keep saying that the test is bad / irrelevant, it is no wonder the author changes the code to improve it. +1 And there have been no major changes. Just comments and return value check changes as per PR comments.
If I understand this correctly, the purpose of the test is to show that the application crashes. In that case, the return value is completely irrelevant. +1 What I don't know: Is there a travis build that shows that the test from Flamefire (https://github.com/boostorg/serialization/pull/111/files ) still fails with the changes introduced by Robert (I'm not sure when they were introduced)? I rebased the changes to develop yesterday. So yes: https://travis-ci.org/boostorg/serialization/jobs/441654483, https://travis-ci.org/boostorg/serialization/jobs/441654485