Hi Edward, On 2015-06-02 22:32, Edward Diener wrote:
The Boost-ready form is what I would like to review but its not only the Boost-ready form that changed but the fact that the documentation set changed ( for the better I will add ). But that's not what was offered for the original review. I don't hold anything against the library author but I don't think I should be required to approve of this ability to change a library in the midst of a review so I voted NO. I think it is going to be really bad, and confusing, to set a precedent by which a library author in the midst of a review, changes the library being reviewed for any reason. My vote can be seen as a protest that this was allowed to happen and has absolutely nothing personal to do with the library author in question.
The documentation set did not change (except for the mpllibs -> boost renaming in that as well). See: https://github.com/sabel83/mpllibs/tree/master/libs/metaparse/doc and https://github.com/sabel83/metaparse/tree/master/doc/src Regards, Ábel