On Fri, Apr 11, 2014 at 8:48 PM, Ahmed Charles
Hi all, Please always state in your review whether you think the library should be accepted as a Boost library.
This library should be accepted as a Boost library.
- What is your evaluation of the design?
Solid and follows existing practices.
- What is your evaluation of the implementation?
The implementation is good and clean. There is one issue in that detecting the alignment of a pointer is done using implementation defined behaviour. But since every compiler implements this the same way, I think it's acceptable.
- What is your evaluation of the documentation?
The documentation is very readable and complete.
- What is your evaluation of the potential usefulness of the library?
I see quite a few use cases for this library and that it adds some much needed functionality that has yet to make it into the standard.
- Did you try to use the library? With what compiler? Did you have any problems?
No.
- How much effort did you put into your evaluation? A glance? A quick reading? In-depth study?
Spent about an hour reading the code and docs.
- Are you knowledgeable about the problem domain?
I'm quite knowledgeable about alignment in C++. I presented at C++Now about the changes to alignment in C++11 and the remaining problems we need to fix. - Michael Spencer