Re: [boost] [nowide] review

2017-06-20 9:47 GMT+02:00 Artyom Beilis via Boost :

...

Hi All. This is a review of Boost.Nowide library. [snip[ DESIGN: clear, logical, intuitive. IMPLEMENTATION: I did not look at. DOCUMENTATION: clear. POTENTIAL USEFULNESS: as specified in the docs, if you want to do things with multilingual strings in a platform independent way, you need a

On Tue, Jun 20, 2017 at 12:28 AM, Andrzej Krzemienski via Boost wrote: library

...

like this.

I vote to *ACCEPT* the library. I may not be qualified enough (the manager will weigh my vote), but the desctiption of the library, as well as the replies from Artyom convince me that the library addresses the problem in the right way and is reliable.

Artyom, thanks for sharing this library, and submitting it for review.

Thank You very much for the review and the inputs.

...

One minor thing. In th be docs (http://cppcms.com/files/nowide/html/) we read: boost::nowide::widen <http://cppcms.com/files/nowide/html/namespaceboost_1_1nowide.html# a6baacc1bb80c134a2ce37f13977b5500> returns std::string.

I thing is thsould be std::wstring?

Regards, &rzej;

Actually this version is for fixed user buffer - function without allocation. So it is right one. Another versions return std::wstring

But when I look into the reference page: http://cppcms.com/files/nowide/html/namespaceboost_1_1nowide.html#a6baacc1bb... I cannot see any overload returning `std::string`? Regards, &rzej;