On 22. Aug 2019, at 15:51, Glen Fernandes
wrote: Hans wrote:
The max/min macro issue does not seem to be relevant anymore in modern compilers. I was completely unaware of this in Boost.Histogram and the code works fine on all msvc versions which support C++14. I added the patches to Histogram to get rid of this warning, but now that code became a lot less readable.
In September 2018, I introduced a use of std::numeric_limits<T>::max() in Boost.CircularBuffer. In November 2018, I received the first of two complaints (from Windows users) so I addressed it.
I'm not convinced that it is not relevant anymore.
Granted, that was November 2018, and it is now August 2019. Many things have happened since then.
For example, as one user has pointed out on this thread, perhaps Brexit has happened.
It is entirely possible that Brexit has caused this to no longer be a problem for Windows developers.
Ok, I stand corrected. This is still an issue and I didn't really understood where the issue is coming from. Thanks to Glen, Paul, and Mike Dev for explaining.