On Wed, Jun 21, 2017 at 12:14 AM, Norbert Wenzel via Boost
This is my review of the proposed Boost.Nowide library.
- What is your evaluation of the design? I had no troubles finding my way. Most APIs are already well known as
On 06/12/2017 06:20 AM, Frédéric Bron via Boost wrote: they resemble APIs from the standard library. I understand (after reading the discussions on this list) why Nowide does not convert all input to a common encoding on all platforms but only deals with wide strings on Windows. It was a bit of a surprise at first, so this design decision should be documented more prominently as others have already pointed out.
Yes indeed I'll have to provide section regarding library policy in tutorial in one of the first sections.
- What is your evaluation of the implementationI did not look at the implementation. It worked as expected/documented when I tested the library.
- What is your evaluation of the documentation? It is enough to start working with the library. I would like to see more clearly for every function when and how input strings are converted to a different encoding and what happens in case of a conversion error (exception, failbit of stream is set, invalid character, etc.).
Indeed - it should be improved.
- Do you think the library should be accepted as a Boost library? Yes.
Norbert
Thank You very much for the review and the comments. Artyom Beilis