On 01/23/2015 05:17 PM, Joel FALCOU wrote:
Is the library ready to be added to Boost releases?
Yes. The documentation is well-written, the code looks clean (except for the multitude of #ifdefs), and the API is superior to N3783. Having said that, I do have a few comments: The endian_reverse() functions assume that there are only two types of endianness (big and little) and that they are the reverse of each other. In practice, this is a feasible assumption. However, once in a while, an odd endianness does show up in this millennia. For example, ARM11 processors uses mix-endian [1] for double. Byte reversal will not handle such cases correctly. The could become a problem during C++ standardization. Why are there no *_int8_t types? [1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0338g/I1844.h...