[endian] undefined behaviour in boost.endian
Hi, I've submitted an issue to the github project for boost.endian. I'm starting to wonder if this is in fact not the preferred channel for reporting issues. There are at least two separate issues causing undefined behaviour to be invoked in boost.endian. The first one is fundamentally based on the assumption that if the target architecture is x86, the C++ alignment requirements don't apply. I've posted more details here: https://github.com/boostorg/endian/issues/21 with a proposed patch here: https://github.com/boostorg/endian/pull/22 The second issue involves shifting negative integers, both invoking implementation defined and undefined behaviour. I don't have a patch to fix the issue, just to extend the tests to exercise the problem, which is then detectible with the undefined behaviour sanitizer. Patch is here: https://github.com/boostorg/endian/pull/24 I would really appreciate it if someone could review these and/or suggest a better venue than github to propose patches. thanks! -- Arvid Norberg
On Wed, Dec 20, 2017 at 11:13 AM, Arvid Norberg via Boost < boost@lists.boost.org> wrote:
Hi, I've submitted an issue to the github project for boost.endian. I'm starting to wonder if this is in fact not the preferred channel for reporting issues.
It looks like you did everything correctly; we have both the Boost Trac site and the Github issues/PRs. In fact I see Peter Dimov is in the process of adding CI build support to the project with a PR in the last 6 hours, which may have been triggered by your original email to this list. It's always good to follow up here if you are not seeing progress in github on your issues. - Jim
On Thu, Dec 21, 2017 at 12:40 AM, James E. King, III via Boost
On Wed, Dec 20, 2017 at 11:13 AM, Arvid Norberg via Boost < boost@lists.boost.org> wrote:
Hi, I've submitted an issue to the github project for boost.endian. I'm starting to wonder if this is in fact not the preferred channel for reporting issues.
It looks like you did everything correctly; we have both the Boost Trac site and the Github issues/PRs. In fact I see Peter Dimov is in the process of adding CI build support to the project with a PR in the last 6 hours, which may have been triggered by your original email to this list. It's always good to follow up here if you are not seeing progress in github on your issues.
I've also submitted issues, emailed Beman but I've failed to receive any response.. -- Olaf
participants (3)
-
Arvid Norberg
-
James E. King, III
-
Olaf van der Spek