[release] Epic fail: Numeric cast in 1.64 does not match trunk
Hello, File https://github.com/boostorg/numeric_conversion/blob/master/include/boost/num... does not match the one in release 1.64 That file was fixed and merged to master a long time ago, however boost_1_64_0.7z archive still has on outdated version (one with std::unary_function). This looks like an issue within some release scripts. Issue was noted here: https://svn.boost.org/trac/boost/ticket/12972 -- Best regards, Antony Polukhin
On 2017-04-24 22:04, Antony Polukhin via Boost wrote:
Hello,
File https://github.com/boostorg/numeric_conversion/blob/master/include/boost/num... does not match the one in release 1.64
That file was fixed and merged to master a long time ago, however boost_1_64_0.7z archive still has on outdated version (one with std::unary_function).
This looks like an issue within some release scripts. Issue was noted here: https://svn.boost.org/trac/boost/ticket/12972
Hi, do i miss something? The file in the first link also uses std::unary_function as the change was revoked by https://github.com/boostorg/numeric_conversion/commit/2009f0d4fc49a6db59b950... Of course, this leaves the question why the change was removed. I guess it broke pre c++17 code. Best, Oswin
2017-04-25 0:07 GMT+03:00 Oswin Krause
On 2017-04-24 22:04, Antony Polukhin via Boost wrote:
Hello,
File
https://github.com/boostorg/numeric_conversion/blob/master/include/boost/num... does not match the one in release 1.64
That file was fixed and merged to master a long time ago, however boost_1_64_0.7z archive still has on outdated version (one with std::unary_function).
This looks like an issue within some release scripts. Issue was noted here: https://svn.boost.org/trac/boost/ticket/12972
Hi,
do i miss something? The file in the first link also uses std::unary_function as the change was revoked by
https://github.com/boostorg/numeric_conversion/commit/2009f0d4fc49a6db59b950...
Oops. That's my epic fault. No idea were I was looking and how have I missed the unary_function. Oh, wait. I was looking at the develop branch and the commit was not reverted in there. Anyway, sorry for the fuss. -- Best regards, Antony Polukhin
2017-04-25 1:09 GMT+03:00 Antony Polukhin via Boost
2017-04-25 0:07 GMT+03:00 Oswin Krause
: On 2017-04-24 22:04, Antony Polukhin via Boost wrote:
Hello,
File
https://github.com/boostorg/numeric_conversion/blob/master/include/boost/num... does not match the one in release 1.64
Anyway, sorry for the fuss.
-- Best regards, Antony Polukhin
Follow up. Can it be possible to add small changes for https://svn.boost.org/trac/boost/wiki/ReleasePractices/ManagerCheckList ? Could you please update 'git tag boost-<version>' with 'git tag -a -m"v<version>" boost-<version>' ? where <version> is current release version. This will provide some mapping between master project and submodules (git submodule status). Thank you. -- Best Regards, Sergei
do i miss something? The file in the first link also uses std::unary_function as the change was revoked by
https://github.com/boostorg/numeric_conversion/commit/2009f0d4fc49a6db59b950...
Of course, this leaves the question why the change was removed. I guess it broke pre c++17 code.
FYI we now have BOOST_NO_CXX98_FUNCTION_BASE for this. Likewise |BOOST_NO_CXX98_RANDOM_SHUFFLE, BOOST_NO_AUTO_PTR and ||BOOST_NO_CXX98_BINDERS.| John. --- This email has been checked for viruses by AVG. http://www.avg.com
participants (4)
-
Antony Polukhin
-
John Maddock
-
Oswin Krause
-
Sergei Nikulov