Re: [boost] [release] Boost 1.70.0 Release Candidate 1 available
On 07/04/2019 15:07, Rainer Deyke via Boost-users wrote:
On 07.04.19 14:13, Marshall Clow via Boost-users wrote:
On Sat, Apr 6, 2019 at 10:53 AM Rainer Deyke via Boost-users < boost-users@lists.boost.org> wrote:
On 04.04.19 16:27, Marshall Clow via Boost-users wrote:
As always, the release managers would appreciate it if you download the candidate of your choice and give building it a try. Please report both success and failure, and anything else that is noteworthy.
boost::movelib::adaptive_merge continues to be broken if iterator_traits<RandIt>::size_type != std::size_t. This breaks boost::container::flat_map when cross-compiling for MacOS. I have previously reported this error here.
I consider this a critical error - as in, I won't be able to upgrade to Boost 1.70 at all unless this error is fixed for the release.
This is https://github.com/boostorg/move/issues/25, correct?
Yes.
Sorry for note replying earlier, I was on a trip. The fix is not complicated but several files need to be modified. Committed to develop: https://github.com/boostorg/move/commit/bfdfca0b88fe1cf4e67b42fcacd5e126e937... @Rainer: I've checked this fix in several msvc and gcc's locally. The error report does not contain any example for the bug, so I don't know if I've fixed your use case. I don't know if we are still on time for 1.70. Best, Ion
On Mon, Apr 8, 2019 at 12:36 AM Ion Gaztañaga via Boost < boost@lists.boost.org> wrote:
On 07/04/2019 15:07, Rainer Deyke via Boost-users wrote:
On 07.04.19 14:13, Marshall Clow via Boost-users wrote:
On Sat, Apr 6, 2019 at 10:53 AM Rainer Deyke via Boost-users < boost-users@lists.boost.org> wrote:
On 04.04.19 16:27, Marshall Clow via Boost-users wrote:
As always, the release managers would appreciate it if you download the candidate of your choice and give building it a try. Please report both success and failure, and anything else that is noteworthy.
boost::movelib::adaptive_merge continues to be broken if iterator_traits<RandIt>::size_type != std::size_t. This breaks boost::container::flat_map when cross-compiling for MacOS. I have previously reported this error here.
I consider this a critical error - as in, I won't be able to upgrade to Boost 1.70 at all unless this error is fixed for the release.
This is https://github.com/boostorg/move/issues/25, correct?
Yes.
Sorry for note replying earlier, I was on a trip. The fix is not complicated but several files need to be modified. Committed to develop:
https://github.com/boostorg/move/commit/bfdfca0b88fe1cf4e67b42fcacd5e126e937...
@Rainer: I've checked this fix in several msvc and gcc's locally. The error report does not contain any example for the bug, so I don't know if I've fixed your use case.
I don't know if we are still on time for 1.70.
That's a more involved fix than I expected. [ and there's a typo in your docs now: "daptive_merge" ] How are the test bots looking? -- Marshall
On 08/04/2019 6:47, Marshall Clow wrote:
That's a more involved fix than I expected. [ and there's a typo in your docs now: "daptive_merge" ]
How are the test bots looking? -- Marshall
Few have cycled. Runners in the develop branch with date "Mon, 08" look ok in Move and Container. I've committed (also in develop) the fix for the typo. Ion
On Sun, Apr 7, 2019 at 9:47 PM Marshall Clow via Boost-users
How are the test bots looking?
Truth be told, they are looking worse for wear and could probably use a vacation to recharge, or perhaps some medical leave. In the meanwhile, you won't believe this - it is actually a rather funny story. Or short story rather, so.... ...it turns out, a user reported another eensy weensy tiny little buggy, this annoying duplicate function template definition problem that happens with friend function templates the fix for which is here: https://github.com/vinniefalco/beast/commit/1de60a046292dcd42bb0097176e0139b... Who could have imagined that someone would report another bug in beast right before rc2 is built? Shocker...
On 2019-04-08 6:19 p.m., Vinnie Falco via Boost wrote:
Who could have imagined that someone would report another bug in beast right before rc2 is built? Shocker...
At this point in time, I'd argue for regressions-only-fixes, to make sure we are actually converging. Stefan -- ...ich hab' noch einen Koffer in Berlin...
On Mon, Apr 8, 2019 at 3:51 PM Stefan Seefeld
At this point in time, I'd argue...fixes, to make sure...
But soft, what commit through yonder git log states? It is a bug, and 5e88637752ea0ecb49824904be3098656740298c is the fix! ... To merge, or not to merge? That is the question. Regards
participants (4)
-
Ion Gaztañaga -
Marshall Clow -
Stefan Seefeld -
Vinnie Falco