On 03/04/2022 05:11, Marshall Clow via Boost wrote:

On Apr 2, 2022, at 1:20 PM, Niall Douglas via Boost wrote:

...

Issue being fixed is https://github.com/ned14/outcome/issues/259 where enabling of move assignment was not calculated correctly.

(To be specific, if both T and E implement move assignment and default construction, but not move nor copy construction, we did not enable move assignment before and with this fix now we do)

Code fixing it is at https://github.com/ned14/outcome/pull/260

Fix passes on develop branch at https://www.boost.org/development/tests/develop/developer/outcome.html

That’s a lot of changes, but if you’re happy with it, go ahead. (Looks like a lot of duplicated changes)

To explain why the duplication, there are trivial and non-trivial storage editions, then three single include file editions. So six copies of the same changes would appear. (Failing to update the single include file editions for a release makes users send complaint emails to me) Niall

On Apr 6, 2022, at 3:01 AM, Niall Douglas via Boost wrote:

On 03/04/2022 05:11, Marshall Clow via Boost wrote:

...

On Apr 2, 2022, at 1:20 PM, Niall Douglas via Boost wrote:

...

Issue being fixed is https://github.com/ned14/outcome/issues/259 where enabling of move assignment was not calculated correctly.

(To be specific, if both T and E implement move assignment and default construction, but not move nor copy construction, we did not enable move assignment before and with this fix now we do)

Code fixing it is at https://github.com/ned14/outcome/pull/260

Fix passes on develop branch at https://www.boost.org/development/tests/develop/developer/outcome.html

That’s a lot of changes, but if you’re happy with it, go ahead. (Looks like a lot of duplicated changes)

Turns out I forgot about `void` in the fix above.

This handles `void` correctly and I added a bunch of extra tests to ensure it is definitely so:

https://github.com/boostorg/outcome/commit/33c97cdf630bef0209d0871bf80eee2d2... https://github.com/boostorg/outcome/commit/33c97cdf630bef0209d0871bf80eee2d2...

Can I get permission to merge this commit to master once https://www.boost.org/development/tests/develop/developer/outcome.html https://www.boost.org/development/tests/develop/developer/outcome.html says it is good?

Once the tests are good, you can go ahead. — Marshall