[vmd] Adding to boost master branch
In an effort to get vmd as a submodule of the boost superproject master branch I submitted a PR against Boost on master ( https://github.com/boostorg/boost/pull/93 ). In this PR I added vmd to .gitmodules and also to the status/jamfile.v2 for testing. But looking at the Travis CI build of this a failure occurs: 0.01s$ cd status The command "cd status" exited with 0. 2.13s$ ../b2 -n -d0 error: Unable to find file or target named error: '../libs/vmd/test/' error: referred to from project at error: '.' There is most definitely a jamfile and tests at libs/vmd/test on the master branch. Is there something else I have to do to get vmd added to the master branch ?
On Tue, Aug 25, 2015 at 12:16 PM, Edward Diener
In an effort to get vmd as a submodule of the boost superproject master branch I submitted a PR against Boost on master ( https://github.com/boostorg/boost/pull/93 ). In this PR I added vmd to .gitmodules and also to the status/jamfile.v2 for testing.
But looking at the Travis CI build of this a failure occurs:
0.01s$ cd status The command "cd status" exited with 0. 2.13s$ ../b2 -n -d0 error: Unable to find file or target named error: '../libs/vmd/test/' error: referred to from project at error: '.'
There is most definitely a jamfile and tests at libs/vmd/test on the master branch.
Is there something else I have to do to get vmd added to the master branch ?
Yes. There's a commit against the "libs/vmd" directory that adds the real git commit reference. Without it git doesn't know to fetch the submodule. In the past I've done some permutation of the "git sudmodule add" command plus editing the ".gitmodules". Then commiting both ".gitmodules" and "libs/vmd" (in your case). The commit, on github, should look like this one < https://github.com/boostorg/boost/commit/8a880f4840a6597fd5de950a925d111a341...
.
-- -- Rene Rivera -- Grafik - Don't Assume Anything -- Robot Dreams - http://robot-dreams.net -- rrivera/acm.org (msn) - grafikrobot/aim,yahoo,skype,efnet,gmail
On 8/25/2015 1:24 PM, Rene Rivera wrote:
On Tue, Aug 25, 2015 at 12:16 PM, Edward Diener
wrote: In an effort to get vmd as a submodule of the boost superproject master branch I submitted a PR against Boost on master ( https://github.com/boostorg/boost/pull/93 ). In this PR I added vmd to .gitmodules and also to the status/jamfile.v2 for testing.
But looking at the Travis CI build of this a failure occurs:
0.01s$ cd status The command "cd status" exited with 0. 2.13s$ ../b2 -n -d0 error: Unable to find file or target named error: '../libs/vmd/test/' error: referred to from project at error: '.'
There is most definitely a jamfile and tests at libs/vmd/test on the master branch.
Is there something else I have to do to get vmd added to the master branch ?
Yes. There's a commit against the "libs/vmd" directory that adds the real git commit reference. Without it git doesn't know to fetch the submodule. In the past I've done some permutation of the "git sudmodule add" command plus editing the ".gitmodules". Then commiting both ".gitmodules" and "libs/vmd" (in your case). The commit, on github, should look like this one < https://github.com/boostorg/boost/commit/8a880f4840a6597fd5de950a925d111a341...
.
Thanks ! I added the vmd submodule to 'master'. Editing .gitmodules by hand originally was definitely wrong.
On 25 August 2015 at 18:16, Edward Diener
Is there something else I have to do to get vmd added to the master branch ?
It doesn't really seem ready for release, e.g. inspect results: http://boost.cowic.de/rc/docs-inspect-develop.html#vmd Has a release manager checked it?
On 8/25/2015 2:11 PM, Daniel James wrote:
On 25 August 2015 at 18:16, Edward Diener
wrote: Is there something else I have to do to get vmd added to the master branch ?
It doesn't really seem ready for release, e.g. inspect results:
http://boost.cowic.de/rc/docs-inspect-develop.html#vmd
Has a release manager checked it?
I will make the necessary corrections. Thanks !
On 8/25/2015 2:11 PM, Daniel James wrote:
On 25 August 2015 at 18:16, Edward Diener
wrote: Is there something else I have to do to get vmd added to the master branch ?
It doesn't really seem ready for release, e.g. inspect results:
http://boost.cowic.de/rc/docs-inspect-develop.html#vmd
Has a release manager checked it?
It should be fixed now so that the inspect report shows no violations for VMD.
participants (3)
-
Daniel James
-
Edward Diener
-
Rene Rivera