[dll] dbghelp.hpp in detail/winapi
Hi, I've noticed that Boost.Dll provides boost/detail/winapi/dbghelp.hpp header. boost/detail/winapi is the directory of Boost.WinAPI submodule, and I generally don't expect anyone else putting his header in that directory. Could dbghelp.hpp be moved somewhere inside boost/dll?
On 2016-02-13 21:18, Andrey Semashev wrote:
Hi,
I've noticed that Boost.Dll provides boost/detail/winapi/dbghelp.hpp header. boost/detail/winapi is the directory of Boost.WinAPI submodule, and I generally don't expect anyone else putting his header in that directory. Could dbghelp.hpp be moved somewhere inside boost/dll?
Also, please, don't define symbols in the boost::detail::winapi namespace.
2016-02-13 21:18 GMT+03:00 Andrey Semashev
Hi,
I've noticed that Boost.Dll provides boost/detail/winapi/dbghelp.hpp header. boost/detail/winapi is the directory of Boost.WinAPI submodule, and I generally don't expect anyone else putting his header in that directory. Could dbghelp.hpp be moved somewhere inside boost/dll?
I was hoping to move boost/detail/winapi/dbghelp.hpp header to Boost.WinAPI submodule. What are the current requirements for winapi headers? I'd appreciate help with tuning dbghelp.hpp header to be suitable for Boost.Winapi. -- Best regards, Antony Polukhin
On 2016-02-13 23:15, Antony Polukhin wrote:
2016-02-13 21:18 GMT+03:00 Andrey Semashev
: Hi,
I've noticed that Boost.Dll provides boost/detail/winapi/dbghelp.hpp header. boost/detail/winapi is the directory of Boost.WinAPI submodule, and I generally don't expect anyone else putting his header in that directory. Could dbghelp.hpp be moved somewhere inside boost/dll?
I was hoping to move boost/detail/winapi/dbghelp.hpp header to Boost.WinAPI submodule.
AFAIK, dbghelp is not part of Windows API but part of a separate package (Windows debugging tools or something). As such I don't think Boost.WinAPI is the right place for it. If multiple libraries are interested in it, you might want to ask to move it to Boost.Detail, for example.
On 13 Feb 2016, at 23:57, Andrey Semashev
wrote: AFAIK, dbghelp is not part of Windows API but part of a separate package (Windows debugging tools or something). As such I don't think Boost.WinAPI is the right place for it.
I’m not sure what qualifies as Windows API but the DLL is shipped with Windows, although usually with an outdated version. Also it’s explicitly allowed to ship newer versions with your software. Source: https://msdn.microsoft.com/en-us/library/ms679294(VS.85).aspx Thomas
On 2016-02-14 10:16, Thomas Trummer wrote:
On 13 Feb 2016, at 23:57, Andrey Semashev
wrote: AFAIK, dbghelp is not part of Windows API but part of a separate package (Windows debugging tools or something). As such I don't think Boost.WinAPI is the right place for it.
I’m not sure what qualifies as Windows API but the DLL is shipped with Windows, although usually with an outdated version. Also it’s explicitly allowed to ship newer versions with your software.
Boost.WinAPI has historically been a replacement for windows.h and dbghelp is not part of it. I also thought it was not part of Windows SDK or the standard Windows distribution, but apparently I was wrong. It's not present in MinGW though. I'll add the header to Boost.WinAPI.
participants (3)
-
Andrey Semashev
-
Antony Polukhin
-
Thomas Trummer