Re: [boost] Formal Review of Proposed Boost.Histogram Library Starts TODAY
- What is your evaluation of the design? The design is excellent, in that is geared towards readability and performance. - What is your evaluation of the implementation? It looks highly optimized with a focus on only being as cheap as possible on CPU. I.e. only pay for what you use. - What is your evaluation of the documentation? Detailed, good examples, I understood everything. - What is your evaluation of the potential usefulness of the library? It's not my domain, but for anyone interested in data analysis this seems super useful. I think there should be more libraries from that domain, even tough it's not my primary one. - Did you try to use the library? With what compiler? Did you have any problems? Yes, I did last year, when it was still in development, I used MinGW 5 and MSVC 2017. No problems. - How much effort did you put into your evaluation? A glance? A quick reading? In-depth study? I looked into the library in depth last year and gave the author my feedback on several implementation details. - Are you knowledgeable about the problem domain? Not in depth, but I know the basics. And finally, every review should answer this question: - Do you think the library should be accepted as a Boost library? Yes, definitely.
Dear Klemens, thank you very much for your kind review!
On 24. Sep 2018, at 22:04, Klemens David Morgenstern via Boost
wrote: - What is your evaluation of the potential usefulness of the library?
It's not my domain, but for anyone interested in data analysis this seems super useful. I think there should be more libraries from that domain, even tough it's not my primary one.
Data analysis is a growing field as everyone knows. There is clearly a demand for histograms, if you search through projects on github, you will find several histogram libraries. The idea of submitting histogram to Boost is to offer a high-quality standard solution that covers everyone's needs - or is at least flexible enough so that it can cover specific needs with a bit of extra work by users (without rewriting the whole thing). If Boost is offering this, there is a high chance that people adopt the standard solution instead of cooking up their own, which leads to less bugs overall and higher code quality.
- Do you think the library should be accepted as a Boost library?
Yes, definitely.
Thank you!
participants (2)
-
Hans Dembinski
-
Klemens David Morgenstern