Adding Metaparse to the master branch
Hi, I've created a pull request to add the Metaparse tests to the Boost regression tests (#113) on the develop branch (Metaparse itself is already part of the develop branch, only the regression test integration is missing). I would like Metaparse to be added to the master branch as well. I have created pull request #112 for that. Please let me know what else is needed. Thanks, Abel
Hi, Are these pull requests waiting on a release manager to look at it (eg. run the tests) or is there something I should do? Regards, Abel On 2016-01-16 23:54, Abel Sinkovics wrote:
Hi,
I've created a pull request to add the Metaparse tests to the Boost regression tests (#113) on the develop branch (Metaparse itself is already part of the develop branch, only the regression test integration is missing).
I would like Metaparse to be added to the master branch as well. I have created pull request #112 for that. Please let me know what else is needed.
Thanks, Abel
On 21-01-16 22:11, Abel Sinkovics wrote:
I would like Metaparse to be added to the master branch as well. I have created pull request #112 for that. Please let me know what else is needed. I think that Marshall Clow replied that the PR should target the development branch? He also wanted to know when adding metaparse was discussed. I linked him to it on github
Seth
On Thu, Jan 21, 2016 at 3:39 PM, Seth
On 21-01-16 22:11, Abel Sinkovics wrote:
I would like Metaparse to be added to the master branch as well. I have created pull request #112 for that. Please let me know what else is needed. I think that Marshall Clow replied that the PR should target the development branch? He also wanted to know when adding metaparse was discussed. I linked him to it on github
I just merge the develop testing addition... Only noticed there was a PR now. And as Marshall said.. We await test results for adding it to master. -- -- Rene Rivera -- Grafik - Don't Assume Anything -- Robot Dreams - http://robot-dreams.net -- rrivera/acm.org (msn) - grafikrobot/aim,yahoo,skype,efnet,gmail
On 2016-01-21 22:41, Rene Rivera wrote:
I just merge the develop testing addition... Only noticed there was a PR now. And as Marshall said.. We await test results for adding it to master.
Thank you Rene. In my understanding, I need to wait for the test results (and the merge) now. Please let me know if there are further steps on my side. Regards, Ábel
Hi Rene, On 2016-01-21 22:41, Rene Rivera wrote:
I just merge the develop testing addition... Only noticed there was a PR now. And as Marshall said.. We await test results for adding it to master.
Did you manage to run the tests? Or should I be running them? Regards, Ábel
On Sat, Jan 30, 2016 at 11:50 AM, Abel Sinkovics
Hi Rene,
On 2016-01-21 22:41, Rene Rivera wrote:
I just merge the develop testing addition... Only noticed there was a PR now. And as Marshall said.. We await test results for adding it to master.
Did you manage to run the tests? Or should I be running them?
Look here: http://www.boost.org/development/tests/develop/developer/metaparse.html -- Marshall
Thank you Marshall, I'll address the failures. Regards, Ábel On 2016-01-31 20:05, Marshall Clow wrote:
On Sat, Jan 30, 2016 at 11:50 AM, Abel Sinkovics
wrote: Hi Rene,
On 2016-01-21 22:41, Rene Rivera wrote:
I just merge the develop testing addition... Only noticed there was a PR now. And as Marshall said.. We await test results for adding it to master.
Did you manage to run the tests? Or should I be running them?
Look here: http://www.boost.org/development/tests/develop/developer/metaparse.html
-- Marshall
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
participants (4)
-
Abel Sinkovics
-
Marshall Clow
-
Rene Rivera
-
Seth