[gil] Can I merge one fix for regression in 1.74?
Dear Release Manager, We've received bug report about regression and have just fixed it in the develop branch of GIL: https://github.com/boostorg/gil/commit/8555ba08cd53c2ec5d65ea60bae9578ad5863... Can I merge this fix to master? Best regards, -- Mateusz Loskot, http://mateusz.loskot.net
On Jul 27, 2020, at 8:36 AM, Mateusz Loskot via Boost
Dear Release Manager,
We've received bug report about regression and have just fixed it in the develop branch of GIL:
https://github.com/boostorg/gil/commit/8555ba08cd53c2ec5d65ea60bae9578ad5863...
Can I merge this fix to master?
I see you committed it to develop 6 minutes ago. ;-) Once the test cycle, and you’re happy with the results, then you can merge to master. — Marshall
On Mon, 27 Jul 2020 at 17:42, Marshall Clow via Boost
On Jul 27, 2020, at 8:36 AM, Mateusz Loskot via Boost
wrote: Dear Release Manager,
We've received bug report about regression and have just fixed it in the develop branch of GIL:
https://github.com/boostorg/gil/commit/8555ba08cd53c2ec5d65ea60bae9578ad5863...
Can I merge this fix to master?
I see you committed it to develop 6 minutes ago. ;-)
Yes, and I also verified the fix manually https://github.com/boostorg/gil/pull/511#pullrequestreview-455895401 The issue is, GIL is still lacking the test coverage for the area where the regression occurred, so I had to verify it using a dedicated sample. We will work on improving the tests soon, after the release though.
Once the test cycle, and you’re happy with the results, then you can merge to master.
Sure, I will wait for the CI builds. Best regards, -- Mateusz Loskot, http://mateusz.loskot.net
participants (2)
-
Marshall Clow
-
Mateusz Loskot