[TR1] Reming TR1? [was: Libraries failing across the board.]
On Wed, Jul 9, 2014 at 8:13 AM, John Maddock
On 08/07/2014 22:07, Beman Dawes wrote:
Marshall is just a few days away from being able to put out a beta release candidate. (And that is very good news!)
But we still have too many libraries failing across the board on master:
accumulators interprocess numeric/ublas pool proto spirit/repository spirit/test tr1
TR1 is now deprecated, and again hasn't been changed in a long time - the main failures seem to be caused by changes to Boost.Random (or possibly std::random) so that it is now no longer TR1 compliant. Someone would have to rewrite it to use TR1-compatible random number classes perhaps culled from an old version of Boost, frankly I just don't see the point. The lib should probably be removed from Boost at some point.
We went back and forth a bit, and decided to remove TR1 after 1.56.0 shipped. What exactly needs to be done? * Remove the .gitmodules entry. * Remove the status/Jamfile.v2 entry. * Remove the libs/maintainer.txt entry. * Update http://www.boost.org/doc/libs/ Anything else? --Beman
We went back and forth a bit, and decided to remove TR1 after 1.56.0 shipped.
What exactly needs to be done?
* Remove the .gitmodules entry. * Remove the status/Jamfile.v2 entry. * Remove the libs/maintainer.txt entry. * Update http://www.boost.org/doc/libs/
Anything else?
Only update the release notes I guess - but it may be too soon for that - do we have any yet? John.
On 8 September 2014 16:28, John Maddock
We went back and forth a bit, and decided to remove TR1 after 1.56.0 shipped.
What exactly needs to be done?
* Remove the .gitmodules entry.
You also need to remove the gitlink. Just use 'git rm libs/tr1/' and git should sort everything out. In older versions this had to be done manually, but it should be automatic now.
* Remove the status/Jamfile.v2 entry. * Remove the libs/maintainer.txt entry.
Also, libs/libraries.htm, and from the documentation build. There's also something in the headers code in Jamroot.
* Update http://www.boost.org/doc/libs/
Anything else?
Only update the release notes I guess - but it may be too soon for that - do we have any yet?
Yes, normal place: https://github.com/boostorg/website/blob/master/feed/history/boost_1_57_0.qb... Also, any repos which use TR1 will need to be updated: algorithm, config, fusion, math, and possibly more.
Beman Dawes wrote:
Anything else?
1) Replace use of unordered_map in boost/algorithm/searching/detail/bm_traits.hpp with a similar local container, or rely on unordered_map from the toolchain. 2) Remove the recursion guards in boost/config/no_tr1. 3) Remove the tr1 tests in config. 4) Remove the tr1 include generated in tools/generate.cpp 5) Remove test/sequence/tr1_tuple_auto_conv.cpp from fusion 6) Update include/boost/smart_ptr/bad_weak_ptr.hpp 7) Figure out if anything should be done about math/tr1.hpp and its test 8) Port other math tests away from tr1::random. Some of those can/should be handled now instead of later. And for completeness, 1) Consider removing references to tr1 from the various quickbooks mentioning it. This is independent and should be done anyway. 2) remove include/boost/type_traits/is_base_of_tr1.hpp from type_traits. Thanks, Steve.
On Sep 16, 2014, at 8:59 AM, Stephen Kelly
Beman Dawes wrote:
Anything else?
1) Replace use of unordered_map in
boost/algorithm/searching/detail/bm_traits.hpp
with a similar local container, or rely on unordered_map from the toolchain.
I can do this. — Marshall
participants (5)
-
Beman Dawes -
Daniel James -
John Maddock -
Marshall Clow -
Stephen Kelly