[release] 1.66.0 post-beta merges

Daniel James

21 Nov 2017 21 Nov '17

3:36 p.m.

The master branch is is now open for post-beta merges, but only as described in the Post-Beta Merge Policy. See https://github.com/boostorg/boost/wiki/Release-Beta-Merge-Policy

Show replies by date

Vinnie Falco

25 Nov 25 Nov

11:39 p.m.

Teeny little problem here: https://github.com/boostorg/asio/pull/67 Three things we can do: 1. Accept the pull request as written 2. Check `n==0` in `detail::buffer_copy_1` 3. Nothing Thanks

Glen Fernandes

26 Nov 26 Nov

12:57 a.m.

On Sat, Nov 25, 2017 at 6:39 PM, Vinnie Falco wrote:

...

Teeny little problem here:

https://github.com/boostorg/asio/pull/67

Three things we can do:

1. Accept the pull request as written 2. Check `n==0` in `detail::buffer_copy_1` 3. Nothing

4. ASIO could use std::copy instead of std::memcpy (Or perhaps that should be '3.' instead) Glen

Daniel James

9:18 a.m.

On 25 November 2017 at 23:39, Vinnie Falco via Boost wrote:

...

Teeny little problem here:

https://github.com/boostorg/asio/pull/67

Three things we can do:

1. Accept the pull request as written 2. Check `n==0` in `detail::buffer_copy_1` 3. Nothing

I'd go for 2 as it doesn't change the data model, but isn't this up to Chris Kohlhoff?

Vinnie Falco

9:46 a.m.

On Sun, Nov 26, 2017 at 1:18 AM, Daniel James via Boost wrote:

...

I'd go for 2 as it doesn't change the data model, but isn't this up to Chris Kohlhoff?

Yes it is ultimately up to Chris. My goal was to provide a few different solutions as food for thought. Thanks

Mike Gresens

10:42 a.m.

New subject: [submodule] boost/blank.hpp

Hi, trying to run a test suite from boost. So performing: git clone -b master --depth 1 https://github.com/boostorg/boost.git boost-root ... git submodule update --init xyz (e.g. tools/build, libs/assert, etc.) Leads to fatal error: boost/blank.hpp Question: Which submodule I have to update to get blank.hpp ?! Thanks, Mike...

Daniel James

10:50 a.m.

New subject: [submodule] boost/blank.hpp

On 26 November 2017 at 10:42, Mike Gresens via Boost wrote:

...

trying to run a test suite from boost. So performing:

git clone -b master --depth 1 https://github.com/boostorg/boost.git boost-root ... git submodule update --init xyz (e.g. tools/build, libs/assert, etc.)

Leads to fatal error: boost/blank.hpp

Question: Which submodule I have to update to get blank.hpp ?!

It's in detail. Btw. the boostdep report is a good place to find out which submodules you need for a particular module: https://pdimov.github.io/boostdep-report/

Mike Gresens

11:16 a.m.

New subject: [submodule] boost/blank.hpp

Great! Thanks a lot! btw: https://pdimov.github.io/boostdep-report/ does not provide searching for "boost/blank.hpp". So still no chance to find the submodule containing this file.. But the submodule for "boost/detail/blank.hpp" would be very easy to find... In my case I want to run test suite of spirit. Looking into https://pdimov.github.io/boostdep-report/ does not help, because there is NO dependency of spirit to detail but to (unknown). Anyway! Thanks a lot again! Mike... Am 26.11.2017 um 11:50 schrieb Daniel James via Boost:

...

On 26 November 2017 at 10:42, Mike Gresens via Boost wrote:

...
trying to run a test suite from boost. So performing:

git clone -b master --depth 1 https://github.com/boostorg/boost.git boost-root ... git submodule update --init xyz (e.g. tools/build, libs/assert, etc.)

Leads to fatal error: boost/blank.hpp

Question: Which submodule I have to update to get blank.hpp ?! It's in detail. Btw. the boostdep report is a good place to find out which submodules you need for a particular module:

https://pdimov.github.io/boostdep-report/

_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost

Peter Dimov

2:54 p.m.

New subject: [submodule] boost/blank.hpp

Mike Gresens wrote:

...

btw:

https://pdimov.github.io/boostdep-report/

does not provide searching for "boost/blank.hpp".

Use boostdep boost/blank.hpp boostdep is the utility that generates the report. http://www.boost.org/doc/libs/master/tools/boostdep/doc/html/

...

In my case I want to run test suite of spirit.

Use what our Travis scripts do: git submodule update --init libs/config git submodule update --init tools/build git submodule update --init tools/boostdep git submodule update --init libs/spirit python tools/boostdep/depinst/depinst.py spirit depinst.py will install the rest.

Avi Kivity

3:12 p.m.

Can I ask that boost.icl be merged from develop to master (and to 1.66 if needed) all of the changes are bug fixes, and are needed for compatibility with newer compilers and other tools. On 11/21/2017 05:36 PM, Daniel James via Boost wrote:

...

The master branch is is now open for post-beta merges, but only as described in the Post-Beta Merge Policy. See https://github.com/boostorg/boost/wiki/Release-Beta-Merge-Policy

_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost

Mike Gresens

27 Nov 27 Nov

10:01 a.m.

New subject: [spirit] Adding spirit repo to travis

Hi, can anybody with permission add the spirit repo to travis? Or can Nikita Kniazev get permission to do that? https://github.com/boostorg/admin/issues/141 Thanks! Mike...

Peter Dimov

10:19 a.m.

New subject: [spirit] Adding spirit repo to travis

Mike Gresens wrote:

...

Hi,

can anybody with permission add the spirit repo to travis?

Activated.

Mike Gresens

7:43 p.m.

New subject: [spirit] Adding spirit repo to appveyor

Hi, can anybody with permission add the spirit repo to appveyor too? Thanks! Mike...

Rene Rivera

7:44 p.m.

New subject: [spirit] Adding spirit repo to appveyor

On Mon, Nov 27, 2017 at 12:43 PM, Mike Gresens via Boost < boost@lists.boost.org> wrote:

...

Hi,

can anybody with permission add the spirit repo to appveyor too?

Add it to your personal Appveyor account. -- -- Rene Rivera -- Grafik - Don't Assume Anything -- Robot Dreams - http://robot-dreams.net

Mike Gresens

7:50 p.m.

New subject: [spirit] Adding spirit repo to appveyor

I did and appveyor runs for commits into MY fork. But how can boostorg/spirit build/run the tests? It's not MY repo - so i can't add it. Mike... Am 27.11.2017 um 20:44 schrieb Rene Rivera via Boost:

...

On Mon, Nov 27, 2017 at 12:43 PM, Mike Gresens via Boost < boost@lists.boost.org> wrote:

...
Hi,

can anybody with permission add the spirit repo to appveyor too?

Add it to your personal Appveyor account.

Andrey Semashev

7:55 p.m.

New subject: [spirit] Adding spirit repo to appveyor

On 11/27/17 22:44, Rene Rivera via Boost wrote:

...

On Mon, Nov 27, 2017 at 12:43 PM, Mike Gresens via Boost < boost@lists.boost.org> wrote:

...
Hi,

can anybody with permission add the spirit repo to appveyor too?

Add it to your personal Appveyor account.

This is not enough. One also has to add an Appveyor hook URL to the GitHub project settings to get automatic builds on commit and PRs. This can only be done by someone with admin permissions.

Rene Rivera

8 p.m.

New subject: [spirit] Adding spirit repo to appveyor

On Mon, Nov 27, 2017 at 12:55 PM, Andrey Semashev via Boost < boost@lists.boost.org> wrote:

...

On 11/27/17 22:44, Rene Rivera via Boost wrote:

...
On Mon, Nov 27, 2017 at 12:43 PM, Mike Gresens via Boost < boost@lists.boost.org> wrote:

Hi,

...
can anybody with permission add the spirit repo to appveyor too?

Add it to your personal Appveyor account.

This is not enough. One also has to add an Appveyor hook URL to the GitHub project settings to get automatic builds on commit and PRs. This can only be done by someone with admin permissions.

OK.. Then ask the owner of Boost Spirit to add it to their personal account. PS. We've never generally added to the Boost appveyor account individual libraries because of the limited build resources that Appveyor has. -- -- Rene Rivera -- Grafik - Don't Assume Anything -- Robot Dreams - http://robot-dreams.net

Andrey Semashev

8:09 p.m.

New subject: [spirit] Adding spirit repo to appveyor

On 11/27/17 23:00, Rene Rivera via Boost wrote:

...

On Mon, Nov 27, 2017 at 12:55 PM, Andrey Semashev via Boost < boost@lists.boost.org> wrote:

...
On 11/27/17 22:44, Rene Rivera via Boost wrote:

...
On Mon, Nov 27, 2017 at 12:43 PM, Mike Gresens via Boost < boost@lists.boost.org> wrote:

Hi,

...
can anybody with permission add the spirit repo to appveyor too?

Add it to your personal Appveyor account.

This is not enough. One also has to add an Appveyor hook URL to the GitHub project settings to get automatic builds on commit and PRs. This can only be done by someone with admin permissions.

OK.. Then ask the owner of Boost Spirit to add it to their personal account.

Yep, this is what this thread is about.

Mike Gresens

8:29 p.m.

New subject: [spirit] Adding spirit repo to appveyor

So, who is the owner of boostorg/spirit? Is it boostorg??!! So here I am and ask boostorg admins to add the spirit repo to appveyor. Thank, Mike... Am 27.11.2017 um 21:09 schrieb Andrey Semashev via Boost:

...

On 11/27/17 23:00, Rene Rivera via Boost wrote:

...
On Mon, Nov 27, 2017 at 12:55 PM, Andrey Semashev via Boost < boost@lists.boost.org> wrote:

...
On 11/27/17 22:44, Rene Rivera via Boost wrote:

...
On Mon, Nov 27, 2017 at 12:43 PM, Mike Gresens via Boost < boost@lists.boost.org> wrote:

Hi,

...
can anybody with permission add the spirit repo to appveyor too?

Add it to your personal Appveyor account.

This is not enough. One also has to add an Appveyor hook URL to the GitHub project settings to get automatic builds on commit and PRs. This can only be done by someone with admin permissions.

OK.. Then ask the owner of Boost Spirit to add it to their personal account.

Yep, this is what this thread is about.

_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost

Peter Dimov

8:35 p.m.

New subject: [spirit] Adding spirit repo to appveyor

Mike Gresens wrote:

...

So, who is the owner of boostorg/spirit? Is it boostorg??!!

So here I am and ask boostorg admins to add the spirit repo to appveyor.

The admin of boostorg/spirit is Joel de Guzman, @djowel. There's also a team "spirit" with write access some of whose members should probably be admins but aren't, such as Hartmut Kaiser (@hkaiser) and Michael Caisse (@mjcaisse).

Joel de Guzman

11 p.m.

New subject: [spirit] Adding spirit repo to appveyor

On 28/11/2017 4:35 AM, Peter Dimov via Boost wrote:

...

Mike Gresens wrote:

...
So, who is the owner of boostorg/spirit? Is it boostorg??!!

So here I am and ask boostorg admins to add the spirit repo to appveyor.

The admin of boostorg/spirit is Joel de Guzman, @djowel.

There's also a team "spirit" with write access some of whose members should probably be admins but aren't, such as Hartmut Kaiser (@hkaiser) and Michael Caisse (@mjcaisse).

Hmmm... Hartmut and Michael should be admins as well. Tell me what I can do about it and this thread's issue. Regards, -- Joel de Guzman

Peter Dimov

11:15 p.m.

New subject: [spirit] Adding spirit repo to appveyor

Joel de Guzman wrote:

...

On 28/11/2017 4:35 AM, Peter Dimov via Boost wrote:

...
Mike Gresens wrote:

...
So, who is the owner of boostorg/spirit? Is it boostorg??!!

So here I am and ask boostorg admins to add the spirit repo to appveyor.

The admin of boostorg/spirit is Joel de Guzman, @djowel.

There's also a team "spirit" with write access some of whose members should probably be admins but aren't, such as Hartmut Kaiser (@hkaiser) and Michael Caisse (@mjcaisse).

Hmmm... Hartmut and Michael should be admins as well. Tell me what I can do about it and this thread's issue.

I added Hartmut and Michael as admins. The problem for which this thread is about is that to enable Travis or Appveyor on Spirit, one needs to be an admin. Nikita Kniazev (who has write access but not admin access) requested to be made an admin in order to work on the CI in https://github.com/boostorg/admin/issues/141, so if you agree, I can do so.

Joel de Guzman

11:33 p.m.

New subject: [spirit] Adding spirit repo to appveyor

On 28/11/2017 7:15 AM, Peter Dimov via Boost wrote:

...

Joel de Guzman wrote:

...
On 28/11/2017 4:35 AM, Peter Dimov via Boost wrote:

...
Mike Gresens wrote:

...
So, who is the owner of boostorg/spirit? Is it boostorg??!!

So here I am and ask boostorg admins to add the spirit repo to >> appveyor.

The admin of boostorg/spirit is Joel de Guzman, @djowel.

There's also a team "spirit" with write access some of whose members > should probably be admins but aren't, such as Hartmut Kaiser (@hkaiser) > and Michael Caisse (@mjcaisse).

Hmmm... Hartmut and Michael should be admins as well. Tell me what I can do about it and this thread's issue.

I added Hartmut and Michael as admins.

The problem for which this thread is about is that to enable Travis or Appveyor on Spirit, one needs to be an admin. Nikita Kniazev (who has write access but not admin access) requested to be made an admin in order to work on the CI in https://github.com/boostorg/admin/issues/141, so if you agree, I can do so.

Yes, please do. He's been a very active maintainer of Spirit recently and has been doing quite a lot of administrative work. Thank you! Regards, -- Joel de Guzman

Gavin Lambert

10:25 p.m.

New subject: [spirit] Adding spirit repo to appveyor

On 28/11/2017 08:43, Mike Gresens wrote:

...

can anybody with permission add the spirit repo to appveyor too?

Note that hitting Reply and then editing the Subject line to make it appear like you are starting a new thread does not actually start a new thread. Please use Reply only for actual replies and use New Message or Compose (or whatever your mail client calls it) when starting new threads.

Francisco José Tapia

29 Nov 29 Nov

11:52 a.m.

Please, could you say me the closing date for the new version? 2017-11-26 16:12 GMT+01:00 Avi Kivity via Boost :

...

Can I ask that boost.icl be merged from develop to master (and to 1.66 if needed) all of the changes are bug fixes, and are needed for compatibility with newer compilers and other tools.

On 11/21/2017 05:36 PM, Daniel James via Boost wrote:

...
The master branch is is now open for post-beta merges, but only as described in the Post-Beta Merge Policy. See https://github.com/boostorg/boost/wiki/Release-Beta-Merge-Policy

_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman /listinfo.cgi/boost

_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman /listinfo.cgi/boost

Olaf van der Spek

1:24 p.m.

On Wed, Nov 29, 2017 at 12:52 PM, Francisco José Tapia via Boost wrote:

...

Please, could you say me the closing date for the new version?

http://www.boost.org/development/index.html

Antony Polukhin

7:12 p.m.

Can I merge develop to master for the Boost.Variant. Develop has a fix for missing include P.S.: I've also merged some doc fixes to master for the Boost.Stacktrace library. -- Best regards, Antony Polukhin

Daniel James

7:20 p.m.

On 29 November 2017 at 19:12, Antony Polukhin via Boost wrote:

...

Can I merge develop to master for the Boost.Variant. Develop has a fix for missing include

Go ahead.

Vicente J. Botet Escriba

18 Dec 18 Dec

12:14 p.m.

Le 29/11/2017 à 20:20, Daniel James via Boost a écrit :

...

On 29 November 2017 at 19:12, Antony Polukhin via Boost wrote:

...
Can I merge develop to master for the Boost.Variant. Develop has a fix for missing include Go ahead.

_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost

Hi, I forgot to merge the win-api replacement for Boost.Thread. https://github.com/boostorg/thread/commit/6d8c0676a13606975e8e45b8fae203ae01... and make use of --abbreviate-paths for windows names. https://github.com/boostorg/thread/commit/5141adee9624b9bad27a3fdeb3d430384f... Can I merge them? Vicente

Andrey Semashev

12:37 p.m.

On 12/18/17 15:14, Vicente J. Botet Escriba via Boost wrote:

...

Le 29/11/2017 à 20:20, Daniel James via Boost a écrit :

...
On 29 November 2017 at 19:12, Antony Polukhin via Boost wrote:

...
Can I merge develop to master for the Boost.Variant. Develop has a fix for missing include Go ahead.

_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost

Hi, I forgot to merge the win-api replacement for Boost.Thread.

https://github.com/boostorg/thread/commit/6d8c0676a13606975e8e45b8fae203ae01...

Interestingly, this is the reason why the Boost.Log tests aren't failing in master because of the https://github.com/boostorg/log/issues/44 issue that I mentioned before.

Vicente J. Botet Escriba

10:30 p.m.

Le 18/12/2017 à 13:37, Andrey Semashev via Boost a écrit :

...

On 12/18/17 15:14, Vicente J. Botet Escriba via Boost wrote:

...
Le 29/11/2017 à 20:20, Daniel James via Boost a écrit :

...
On 29 November 2017 at 19:12, Antony Polukhin via Boost wrote:

...
Can I merge develop to master for the Boost.Variant. Develop has a fix for missing include Go ahead.

_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost

Hi, I forgot to merge the win-api replacement for Boost.Thread.

https://github.com/boostorg/thread/commit/6d8c0676a13606975e8e45b8fae203ae01...

Interestingly, this is the reason why the Boost.Log tests aren't failing in master because of the https://github.com/boostorg/log/issues/44 issue that I mentioned before.

So If I understand it is not critical, an I could wait for boost 1.67, isn't it? Vicente

Andrey Semashev

10:46 p.m.

On 12/19/17 01:30, Vicente J. Botet Escriba wrote:

...

Le 18/12/2017 à 13:37, Andrey Semashev via Boost a écrit :

...
On 12/18/17 15:14, Vicente J. Botet Escriba via Boost wrote:

...
Le 29/11/2017 à 20:20, Daniel James via Boost a écrit :

...
On 29 November 2017 at 19:12, Antony Polukhin via Boost wrote:

...
Can I merge develop to master for the Boost.Variant. Develop has a fix for missing include Go ahead.

_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost

Hi, I forgot to merge the win-api replacement for Boost.Thread.

https://github.com/boostorg/thread/commit/6d8c0676a13606975e8e45b8fae203ae01...

Interestingly, this is the reason why the Boost.Log tests aren't failing in master because of the https://github.com/boostorg/log/issues/44 issue that I mentioned before.

So If I understand it is not critical, an I could wait for boost 1.67, isn't it?

1.66 has been released and my fix is in master now. You can merge the change.

Vicente J. Botet Escriba

19 Dec 19 Dec

2:18 a.m.

Le 18/12/2017 à 23:46, Andrey Semashev via Boost a écrit :

...

On 12/19/17 01:30, Vicente J. Botet Escriba wrote:

...
Le 18/12/2017 à 13:37, Andrey Semashev via Boost a écrit :

...
On 12/18/17 15:14, Vicente J. Botet Escriba via Boost wrote:

...
Le 29/11/2017 à 20:20, Daniel James via Boost a écrit :

...
On 29 November 2017 at 19:12, Antony Polukhin via Boost wrote:

...
Can I merge develop to master for the Boost.Variant. Develop has a fix for missing include Go ahead.

_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost

Hi, I forgot to merge the win-api replacement for Boost.Thread.

https://github.com/boostorg/thread/commit/6d8c0676a13606975e8e45b8fae203ae01...

Interestingly, this is the reason why the Boost.Log tests aren't failing in master because of the https://github.com/boostorg/log/issues/44 issue that I mentioned before.

So If I understand it is not critical, an I could wait for boost 1.67, isn't it?

1.66 has been released and my fix is in master now. You can merge the change.

I'll wait until the master branch is unfrozen. Vicente

2534

Age (days ago)

2562

Last active (days ago)

List overview

Download

32 comments

14 participants

participants (14)

Andrey Semashev
Antony Polukhin
Avi Kivity
Daniel James
Francisco José Tapia
Gavin Lambert
Glen Fernandes
Joel de Guzman
Mike Gresens
Olaf van der Spek
Peter Dimov
Rene Rivera
Vicente J. Botet Escriba
Vinnie Falco