[thread] Build failures in develop
Hi, Boost.Thread currently fails to build on MSVC, which affects other libraries: http://www.boost.org/development/tests/develop/developer/output/teeks99-08d-... Could it be fixed?
On 30 Sep 2014 at 11:23, Andrey Semashev wrote:
Boost.Thread currently fails to build on MSVC, which affects other libraries:
Looks like it came from the WinRT patch and only occurs if BOOST_USE_WINDOWS_H is turned on. I'd say you need a WinRT capable Windows SDK. Niall -- ned Productions Limited Consulting http://www.nedproductions.biz/ http://ie.linkedin.com/in/nialldouglas/
On Tue, Sep 30, 2014 at 11:46 AM, Niall Douglas
On 30 Sep 2014 at 11:23, Andrey Semashev wrote:
Boost.Thread currently fails to build on MSVC, which affects other libraries:
Looks like it came from the WinRT patch and only occurs if BOOST_USE_WINDOWS_H is turned on.
I'd say you need a WinRT capable Windows SDK.
I think the code should be compatible with SDK for any Windows version we support. If I'm not mistaken, it should be at least Windows XP and later.
Niall Douglas
On 30 Sep 2014 at 11:23, Andrey Semashev wrote:
Boost.Thread currently fails to build on MSVC, which affects other libraries:
Looks like it came from the WinRT patch and only occurs if BOOST_USE_WINDOWS_H is turned on.
CREATE_EVENT_MANUAL_RESET and CREATE_EVENT_INITIAL_SET are only defined for (_WIN32_WINNT >= 0x0600) in the Windows SDK. As they are only used in a (BOOST_USE_WINAPI_VERSION >= BOOST_WINAPI_VERSION_VISTA) block and boost::detail::win32::CreateEventExW is only defined in such a block, the defines should probably be guarded by that too.
On Tuesday 30 September 2014 09:27:18 Marcel Raad wrote:
Niall Douglas
writes: On 30 Sep 2014 at 11:23, Andrey Semashev wrote:
Boost.Thread currently fails to build on MSVC, which affects other
libraries: Looks like it came from the WinRT patch and only occurs if BOOST_USE_WINDOWS_H is turned on.
CREATE_EVENT_MANUAL_RESET and CREATE_EVENT_INITIAL_SET are only defined for (_WIN32_WINNT >= 0x0600) in the Windows SDK.
As they are only used in a (BOOST_USE_WINAPI_VERSION >= BOOST_WINAPI_VERSION_VISTA) block and boost::detail::win32::CreateEventExW is only defined in such a block, the defines should probably be guarded by that too.
As far as I can see these macros are unconditionally defined in SDK v6.0A and not defined in v5.0. Apparently, MinGW also doesn't have them. So it's better to just always use numeric constants. https://github.com/boostorg/thread/pull/26
Le 30/09/14 20:34, Andrey Semashev a écrit :
On Tuesday 30 September 2014 09:27:18 Marcel Raad wrote:
Niall Douglas
writes: On 30 Sep 2014 at 11:23, Andrey Semashev wrote:
Boost.Thread currently fails to build on MSVC, which affects other libraries: Looks like it came from the WinRT patch and only occurs if BOOST_USE_WINDOWS_H is turned on. CREATE_EVENT_MANUAL_RESET and CREATE_EVENT_INITIAL_SET are only defined for (_WIN32_WINNT >= 0x0600) in the Windows SDK.
As they are only used in a (BOOST_USE_WINAPI_VERSION >= BOOST_WINAPI_VERSION_VISTA) block and boost::detail::win32::CreateEventExW is only defined in such a block, the defines should probably be guarded by that too. As far as I can see these macros are unconditionally defined in SDK v6.0A and not defined in v5.0. Apparently, MinGW also doesn't have them. So it's better to just always use numeric constants.
I've merged your patch. I hope this will fix the failures on develop :( Vicente
On Wed, Oct 1, 2014 at 2:39 AM, Vicente J. Botet Escriba
Le 30/09/14 20:34, Andrey Semashev a écrit :
As far as I can see these macros are unconditionally defined in SDK v6.0A and not defined in v5.0. Apparently, MinGW also doesn't have them. So it's better to just always use numeric constants.
I've merged your patch. I hope this will fix the failures on develop :(
Thanks.
participants (4)
-
Andrey Semashev -
Marcel Raad -
Niall Douglas -
Vicente J. Botet Escriba