[filesystem] Pull request needs attention
I have fixed a crash I found due to static initialization ordering in boost filesystem. I have a proposed fix here: https://github.com/boostorg/filesystem/pull/47 It hasn't gotten any attention yet, so I'm hoping someone can offer some advice and/or merge the PR for me. Thanks in advance.
Am 08.08.2017 um 18:20 schrieb Robert Dailey via Boost-users:
I have fixed a crash I found due to static initialization ordering in boost filesystem. I have a proposed fix here: https://github.com/boostorg/filesystem/pull/47
There is actually an even older (from april) pull request https://github.com/boostorg/filesystem/pull/43 (by me) open on the very same subject. Ciao Dani
On Tue, Aug 8, 2017 at 12:07 PM, Daniela Engert
Am 08.08.2017 um 18:20 schrieb Robert Dailey via Boost-users:
I have fixed a crash I found due to static initialization ordering in boost filesystem. I have a proposed fix here: https://github.com/boostorg/filesystem/pull/47
There is actually an even older (from april) pull request https://github.com/boostorg/filesystem/pull/43 (by me) open on the very same subject.
Ciao Dani
Ah I didn't realize someone else had solved this problem. I will close mine in favor of yours. I don't quite understand why they're trying to share globals/statics between threads without some synchronization, but it's not my battle to deal with. I just want the code to work and not crash my application. Thanks for the reply.
On Tue, Aug 8, 2017 at 12:20 PM, Robert Dailey via Boost < boost@lists.boost.org> wrote:
I have fixed a crash I found due to static initialization ordering in boost filesystem. I have a proposed fix here: https://github.com/boostorg/filesystem/pull/47
It hasn't gotten any attention yet, so I'm hoping someone can offer some advice and/or merge the PR for me. Thanks in advance.
I'm hoping in the next month or two to clear all outstanding filesystem pull requests. That's a prerequisite for filesystem V4, which will bring the Boost implementation into compliance with C++17 Filesystem. --Beman
participants (3)
-
Beman Dawes -
Daniela Engert -
Robert Dailey