[Boost.MSM] Please, update master with changes from develop
Hello world, I just stumbled across a compilation-error with the latest Boost release (1.71) of Boost.MSM for which I already provided a merge-request [1] a year ago, and which was merged to "develop" branch at that time, too. Still, the "master" branch lags this merge-request (and a lot more [2] from former years which are in "develop") but has some other unrelated merge-requests [3] merged in which are not in "develop". I would love seeing "develop" being merged into "master" (and maybe vise-versa) so that bugs for which fixes already exist will no longer be present in the next Boost release. Thanks for taking care of. Deniz [1] https://github.com/boostorg/msm/pull/15 [2] https://github.com/boostorg/msm/compare/master...develop [3] https://github.com/boostorg/msm/compare/develop...master
Christophe, are you still maintaining Boost.MSM? (I hope you do.) Would it be possible to merge branch "develop" into "master"? Thanks a lot, Deniz Am 04.09.19 um 12:47 schrieb Deniz Bahadir via Boost:
Hello world,
I just stumbled across a compilation-error with the latest Boost release (1.71) of Boost.MSM for which I already provided a merge-request [1] a year ago, and which was merged to "develop" branch at that time, too.
Still, the "master" branch lags this merge-request (and a lot more [2] from former years which are in "develop") but has some other unrelated merge-requests [3] merged in which are not in "develop".
I would love seeing "develop" being merged into "master" (and maybe vise-versa) so that bugs for which fixes already exist will no longer be present in the next Boost release.
Thanks for taking care of. Deniz
[1] https://github.com/boostorg/msm/pull/15 [2] https://github.com/boostorg/msm/compare/master...develop [3] https://github.com/boostorg/msm/compare/develop...master
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
On Tue, Oct 8, 2019 at 5:23 AM Deniz Bahadir via Boost
I just stumbled across a compilation-error with the latest Boost release (1.71) of Boost.MSM for which I already provided a merge-request [1] a year ago, and which was merged to "develop" branch at that time, too.
The __cplusplus < 201703L check should probably be: defined(BOOST_NO_CXX98_RANDOM_SHUFFLE) As for the __cplusplus >= 201103L check it would be nice it were something like: !defined(BOOST_NO_CXX11_HDR_ALGORITHM) or !defined(BOOST_NO_CXX11_STD_SHUFFLE) but we don't have those two macros yet. (But any implementation for which defined(BOOST_NO_CXX98_RANDOM_SHUFFLE) is true is probably going to have std::shuffle). Glen
participants (3)
-
Deniz Bahadir
-
Deniz Bahadir
-
Glen Fernandes