when can a trac ticket be considered closed

newer
[TypeIndex 3.0] Review Manager's...

Andrzej Krzemienski

2 May 2014 2 May '14

3:27 p.m.

Hi Everyone, Sorry for the silly question; at which point in Modular Boost Library workflow should I close a Trac ticket? Is it when I commit the relevant changes to branch master? Regards, &rzej

Show replies by date

Marshall Clow

4 May 4 May

1:48 p.m.

On May 2, 2014, at 8:27 AM, Andrzej Krzemienski wrote:

...

Hi Everyone, Sorry for the silly question; at which point in Modular Boost Library workflow should I close a Trac ticket? Is it when I commit the relevant changes to branch master?

That would be a good time. — Marshall

Klaim - Joël Lamotte

2:02 p.m.

On Sun, May 4, 2014 at 3:48 PM, Marshall Clow wrote:

...

That would be a good time.

I remember Boost.Test's maintainer stating that he would close some open tickets that have been fixed only once the fixed release is out. So there seem to be a disagreement on this? My opinion is that as long as a fixed issue have an explicit associated changeset id or release target, then closing it once it's done should be ok.

Marshall Clow

3:02 p.m.

On May 4, 2014, at 7:02 AM, Klaim - Joël Lamotte wrote:

...

On Sun, May 4, 2014 at 3:48 PM, Marshall Clow wrote:

...
That would be a good time.

I remember Boost.Test's maintainer stating that he would close some open tickets that have been fixed only once the fixed release is out. So there seem to be a disagreement on this?

My opinion is that as long as a fixed issue have an explicit associated changeset id or release target, then closing it once it's done should be ok.

Like so many things in Boost, this is up to the individual library developers. In general, what _I_ do is: 1) update the ticket when a fix is committed to develop. 2) Close the ticket when the fix is merged to master. — Marshall

Klaim - Joël Lamotte

3:11 p.m.

On Sun, May 4, 2014 at 5:02 PM, Marshall Clow wrote:

...

Like so many things in Boost, this is up to the individual library developers.

In general, what _I_ do is: 1) update the ticket when a fix is committed to develop. 2) Close the ticket when the fix is merged to master.

Would a ticket state that would mean "done/fixed in repo but not released yet" help clarify things for both maintainers and users?

Paul A. Bristow

3:37 p.m.

...

-----Original Message----- From: Boost [mailto:boost-bounces@lists.boost.org] On Behalf Of Klaim - Joël Lamotte Sent: 04 May 2014 16:11 To: Boost Developers List Subject: Re: [boost] when can a trac ticket be considered closed

On Sun, May 4, 2014 at 5:02 PM, Marshall Clow wrote:

...
Like so many things in Boost, this is up to the individual library developers.

In general, what _I_ do is: 1) update the ticket when a fix is committed to develop. 2) Close the ticket when the fix is merged to master.

Would a ticket state that would mean "done/fixed in repo but not released yet" help clarify things for both maintainers and users?

Well, as a maintainer, I may think that I've fixed and tested, but I'd like confirmation from user(s) that *they* agree it is fixed for them too. 'Pushed to develop' tells users that if they want a 'hot fix', then go to modular-boost/develop and pick it up. 'Pushed to master' tells users that this is a fix that will be in the next release. So I'd favour a ticket state for both of these, or at least some convention about what 'fixed' means. My two-pennyworth. Paul --- Paul A. Bristow Prizet Farmhouse Kendal UK LA8 8AB +44 01539 561830

Klaim - Joël Lamotte

3:46 p.m.

On Sun, May 4, 2014 at 5:37 PM, Paul A. Bristow wrote:

...

Well, as a maintainer, I may think that I've fixed and tested, but I'd like confirmation from user(s) that *they* agree it is fixed for them too.

'Pushed to develop' tells users that if they want a 'hot fix', then go to modular-boost/develop and pick it up.

'Pushed to master' tells users that this is a fix that will be in the next release.

So I'd favour a ticket state for both of these, or at least some convention about what 'fixed' means.

It looks like "ready for testing" kind of state, then "tested/validated by testers" but Boost don't have a QA so it's a bit different.

3990

Age (days ago)

3992

Last active (days ago)

List overview

Download

6 comments

4 participants

participants (4)

Andrzej Krzemienski
Klaim - Joël Lamotte
Marshall Clow
Paul A. Bristow