Proposed BoostBook fix for invalid <h7> and <h8> elements
Hello, The DocBook stylesheets used by BoostBook occasionally will output invalid heading elements (<h7> or <h8>). Some (but not all!) areas of the stylesheets properly cap the output to <h6>. In particular, the rule for <bridgehead> fails to do this. The consequences are described in this BoostBook issue: https://github.com/boostorg/boostbook/issues/12 And (originally) in this issue in the docca tool, which depends on BoostBook: https://github.com/boostorg/docca/issues/79 I have created a pull request that fixes the DocBook issue by overriding the bridgehead rule. Although the ideal fix would be in the DocBook stylesheets themselves, these stylesheets are no longer being regularly updated. Also, my proposed fix conforms to the pattern of other BoostBook-specific stylesheet overrides. Is there someone familiar with BoostBook who would be willing to review my pull request (and raise any questions or concerns as desired)? https://github.com/boostorg/boostbook/pull/13 Thanks very much for your time! Evan Lenz
By chance is there anyone who would be willing to review this BoostBook
pull request? https://github.com/boostorg/boostbook/pull/13
Thank you!
Evan
On Tue, Feb 8, 2022 at 6:46 PM Evan Lenz
Hello,
The DocBook stylesheets used by BoostBook occasionally will output invalid heading elements (<h7> or <h8>). Some (but not all!) areas of the stylesheets properly cap the output to <h6>. In particular, the rule for <bridgehead> fails to do this.
The consequences are described in this BoostBook issue: https://github.com/boostorg/boostbook/issues/12
And (originally) in this issue in the docca tool, which depends on BoostBook: https://github.com/boostorg/docca/issues/79
I have created a pull request that fixes the DocBook issue by overriding the bridgehead rule. Although the ideal fix would be in the DocBook stylesheets themselves, these stylesheets are no longer being regularly updated. Also, my proposed fix conforms to the pattern of other BoostBook-specific stylesheet overrides.
Is there someone familiar with BoostBook who would be willing to review my pull request (and raise any questions or concerns as desired)? https://github.com/boostorg/boostbook/pull/13
Thanks very much for your time! Evan Lenz
On Sun, Feb 13, 2022 at 6:32 PM Evan Lenz via Boost
By chance is there anyone who would be willing to review this BoostBook pull request? https://github.com/boostorg/boostbook/pull/13
This is the first I am seeing the original post, was it stuck in the moderation queue? Thanks
On Mon, Feb 14, 2022 at 12:48 AM Vinnie Falco wrote:
On Sun, Feb 13, 2022 at 6:32 PM Evan Lenz via Boost wrote:
By chance is there anyone who would be willing to review this BoostBook pull request? https://github.com/boostorg/boostbook/pull/13
This is the first I am seeing the original post, was it stuck in the moderation queue?
The original post made it to everyone: https://lists.boost.org/Archives/boost/2022/02/252449.php Glen
participants (3)
-
Evan Lenz
-
Glen Fernandes
-
Vinnie Falco