[GitHub] List open pull requests for all libraries? [resend]

newer
Re: [boost] Community Maintenance...

Beman Dawes

13 May 2014 13 May '14

1:23 p.m.

We need to be able to monitor the open pull requests for all Boost libraries, not just a individual library. I'm not seeing any canned way of doing that via the GitHub web site. Am I missing something? It does seem possible to access the required information via the GitHub API. Is that the best approach to take? Does anyone know how to do this? Thanks, --Beman

Show replies by date

Daniel James

13 May 13 May

3:09 p.m.

New subject: [GitHub] List open pull requests for all libraries? [resend]

On 13 May 2014 14:23, Beman Dawes wrote:

...

It does seem possible to access the required information via the GitHub API. Is that the best approach to take? Does anyone know how to do this?

I think I can create a page on the web site. I'm already using the API to update the super project.

Daniel James

7:38 p.m.

New subject: [GitHub] List open pull requests for all libraries? [resend]

On 13 May 2014 16:09, Daniel James wrote:

...

On 13 May 2014 14:23, Beman Dawes wrote:

...
It does seem possible to access the required information via the GitHub API. Is that the best approach to take? Does anyone know how to do this?

I think I can create a page on the web site. I'm already using the API to update the super project.

Here's a proof of concept: http://boost.cowic.de/rc/pull_requests.html I'll try to do something more functional soon-ish.

Beman Dawes

8:41 p.m.

New subject: [GitHub] List open pull requests for all libraries? [resend]

On Tue, May 13, 2014 at 1:38 PM, Daniel James wrote:

...

On 13 May 2014 16:09, Daniel James wrote:

...
On 13 May 2014 14:23, Beman Dawes wrote:

...
It does seem possible to access the required information via the GitHub API. Is that the best approach to take? Does anyone know how to do this?

I think I can create a page on the web site. I'm already using the API to update the super project.

Here's a proof of concept:

http://boost.cowic.de/rc/pull_requests.html

I'll try to do something more functional soon-ish. http://lists.boost.org/mailman/listinfo.cgi/boost

That's a great start! The one additional piece of information that would be helpful is the date the pull request was submitted. --Beman

Klaim - Joël Lamotte

8:56 p.m.

New subject: [GitHub] List open pull requests for all libraries? [resend]

On Tue, May 13, 2014 at 10:41 PM, Beman Dawes wrote:

...

That's a great start! The one additional piece of information that would be helpful is the date the pull request was submitted.

I think that added to that, a clear time passed since that date would help realize faster which ones are old.

Adam Wulkiewicz

14 May 14 May

10:42 a.m.

New subject: [GitHub] List open pull requests for all libraries? [resend]

Klaim - Joël Lamotte wrote:

...

On Tue, May 13, 2014 at 10:41 PM, Beman Dawes wrote:

...
That's a great start! The one additional piece of information that would be helpful is the date the pull request was submitted.

I think that added to that, a clear time passed since that date would help realize faster which ones are old.

Would it be possible to extract the number of comments or even better the time of the lastcomment in the pull request? This would allow to distinguish between no-response and work-in-progress cases to not generate unneeded notifications. Or to made 2-phase notification, warning based on a pull request creation date and alarm based on the time of the last activity. Regards, Adam

Daniel James

11:08 a.m.

New subject: [GitHub] List open pull requests for all libraries? [resend]

On 14 May 2014 11:42, Adam Wulkiewicz wrote:

...

Klaim - Joël Lamotte wrote:

...
On Tue, May 13, 2014 at 10:41 PM, Beman Dawes wrote:

...
That's a great start! The one additional piece of information that would be helpful is the date the pull request was submitted.

I think that added to that, a clear time passed since that date would help realize faster which ones are old.

Would it be possible to extract the number of comments or even better the time of the lastcomment in the pull request? This would allow to distinguish between no-response and work-in-progress cases to not generate unneeded notifications. Or to made 2-phase notification, warning based on a pull request creation date and alarm based on the time of the last activity.

Yes, but I want to keep the initial version simple. Btw. I've been talking about using the events api, I just realised that the notification api might be easier to use here.

Glen Fernandes

13 May 13 May

9:18 p.m.

New subject: [GitHub] List open pull requests for all libraries? [resend]

On Tue, May 13, 2014 at 1:41 PM, Beman Dawes wrote:

...

On Tue, May 13, 2014 at 1:38 PM, Daniel James wrote:

...
Here's a proof of concept:

http://boost.cowic.de/rc/pull_requests.html

I'll try to do something more functional soon-ish. http://lists.boost.org/mailman/listinfo.cgi/boost

That's a great start! The one additional piece of information that would be helpful is the date the pull request was submitted.

Seconded: This is very nice. When integrated into boost.org, would this be updated daily or upon each pull request submission and merge? Glen

Marshall Clow

9:26 p.m.

New subject: [GitHub] List open pull requests for all libraries? [resend]

On May 13, 2014, at 3:18 PM, Glen Fernandes wrote:

...

On Tue, May 13, 2014 at 1:41 PM, Beman Dawes wrote:

...
On Tue, May 13, 2014 at 1:38 PM, Daniel James wrote:

...
Here's a proof of concept:

http://boost.cowic.de/rc/pull_requests.html

I'll try to do something more functional soon-ish. http://lists.boost.org/mailman/listinfo.cgi/boost

That's a great start! The one additional piece of information that would be helpful is the date the pull request was submitted.

Seconded: This is very nice.

When integrated into boost.org, would this be updated daily or upon each pull request submission and merge?

How hard is this page to generate? Is this something that can be generated “on the fly”? (instead of every day/hour/request/whatever)? — Marshall P.S. Very nice.

Vladimir Prus

14 May 14 May

7:31 a.m.

New subject: [GitHub] List open pull requests for all libraries? [resend]

On 05/14/2014 01:26 AM, Marshall Clow wrote:

...

On May 13, 2014, at 3:18 PM, Glen Fernandes wrote:

...
On Tue, May 13, 2014 at 1:41 PM, Beman Dawes wrote:

...
On Tue, May 13, 2014 at 1:38 PM, Daniel James wrote:

...
Here's a proof of concept:

http://boost.cowic.de/rc/pull_requests.html

I'll try to do something more functional soon-ish. http://lists.boost.org/mailman/listinfo.cgi/boost

That's a great start! The one additional piece of information that would be helpful is the date the pull request was submitted.

Seconded: This is very nice.

When integrated into boost.org, would this be updated daily or upon each pull request submission and merge?

How hard is this page to generate? Is this something that can be generated “on the fly”? (instead of every day/hour/request/whatever)?

Quoting: For requests using Basic Authentication or OAuth, you can make up to 5,000 requests per hour. For unauthenticated requests, the rate limit allows you to make up to 60 requests per hour. There's 123 repositories, so if 40 people hit the page within an hour, we're out of the limit. And I would guess if any link it posted to ML, the number of people who will click it will be higher than that. - Volodya

Daniel James

8:24 a.m.

New subject: [GitHub] List open pull requests for all libraries? [resend]

On 14 May 2014 08:31, Vladimir Prus wrote:

...

Quoting:

For requests using Basic Authentication or OAuth, you can make up to 5,000 requests per hour. For unauthenticated requests, the rate limit allows you to make up to 60 requests per hour.

There's 123 repositories, so if 40 people hit the page within an hour, we're out of the limit. And I would guess if any link it posted to ML, the number of people who will click it will be higher than that.

I don't think github counts requests when the etag matches, so it's not that bad. But over a 100 checks is still too much to do for every request. It might be possible to do better by using the events api to find out what has updated since the last run, and caching the results to limit how many often that's done.

Niall Douglas

10:56 p.m.

New subject: [GitHub] List open pull requests for all libraries? [resend]

On 14 May 2014 at 11:31, Vladimir Prus wrote:

...

...
How hard is this page to generate? Is this something that can be generated "on the fly"? (instead of every day/hour/request/whatever)?

There's 123 repositories, so if 40 people hit the page within an hour, we're out of the limit. And I would guess if any link it posted to ML, the number of people who will click it will be higher than that.

A varnish reverse proxy would fix that in a cinch. Simply set a TTL of two minutes. Niall -- ned Productions Limited Consulting http://www.nedproductions.biz/ http://ie.linkedin.com/in/nialldouglas/

Daniel James

15 May 15 May

6:36 a.m.

New subject: [GitHub] List open pull requests for all libraries? [resend]

On 14 May 2014 23:56, Niall Douglas wrote:

...

On 14 May 2014 at 11:31, Vladimir Prus wrote:

...
...
How hard is this page to generate? Is this something that can be generated "on the fly"? (instead of every day/hour/request/whatever)?

There's 123 repositories, so if 40 people hit the page within an hour, we're out of the limit. And I would guess if any link it posted to ML, the number of people who will click it will be higher than that.

A varnish reverse proxy would fix that in a cinch. Simply set a TTL of two minutes.

The response time for requests that aren't cached would be terrible, and it would be likely to fail whenever github is overwhelmed.

Niall Douglas

5:55 p.m.

New subject: [GitHub] List open pull requests for all libraries? [resend]

On 15 May 2014 at 7:36, Daniel James wrote:

...

...
...
...
How hard is this page to generate? Is this something that can be generated "on the fly"? (instead of every day/hour/request/whatever)?

There's 123 repositories, so if 40 people hit the page within an hour, we're out of the limit. And I would guess if any link it posted to ML, the number of people who will click it will be higher than that.

A varnish reverse proxy would fix that in a cinch. Simply set a TTL of two minutes.

The response time for requests that aren't cached would be terrible, and it would be likely to fail whenever github is overwhelmed.

I'm not sure why you think that. https://ci.nedprod.com/ comes out of a varnish cache with the actual server sitting behind an OpenVPN in a home residential connection. Ping times are far more awful than they would be with a github API wrap, yet the CI website is perfectly okay to use. varnish knows how to serve stale content when the home DSL dies too. Rather more relevant to these discussions, a list of outstanding pull requests need - with minimal work - not exceed github limits. You can fire and forget. Niall -- ned Productions Limited Consulting http://www.nedproductions.biz/ http://ie.linkedin.com/in/nialldouglas/

Daniel James

13 May 13 May

9:32 p.m.

New subject: [GitHub] List open pull requests for all libraries? [resend]

On 13 May 2014 22:18, Glen Fernandes wrote:

...

On Tue, May 13, 2014 at 1:41 PM, Beman Dawes wrote:

...
On Tue, May 13, 2014 at 1:38 PM, Daniel James wrote:

...
Here's a proof of concept:

http://boost.cowic.de/rc/pull_requests.html

I'll try to do something more functional soon-ish. http://lists.boost.org/mailman/listinfo.cgi/boost

That's a great start! The one additional piece of information that would be helpful is the date the pull request was submitted.

Seconded: This is very nice.

When integrated into boost.org, would this be updated daily or upon each pull request submission and merge?

Daily at first. But later I will try to use the events api to update individual repos more frequently - although there will still be a bit of a delay.

3848

Age (days ago)

3850

Last active (days ago)

List overview

Download

14 comments

8 participants

participants (8)

Adam Wulkiewicz
Beman Dawes
Daniel James
Glen Fernandes
Klaim - Joël Lamotte
Marshall Clow
Niall Douglas
Vladimir Prus